Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: chrome/renderer/resources/extensions/types_custom_bindings.js

Issue 10535030: Allow updateArgumentsPostValidate to support callbacks and added / removed arguments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Proper syntax Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/types_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/types_custom_bindings.js b/chrome/renderer/resources/extensions/types_custom_bindings.js
index daf029a7907e186b3012f10bed4e946e09b32bef..4af67b4dac54a1681590213156aeb6fffc544e4d 100644
--- a/chrome/renderer/resources/extensions/types_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/types_custom_bindings.js
@@ -6,6 +6,7 @@
var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
var sendRequest = require('sendRequest').sendRequest;
+var validate = require('schemaUtils').validate;
chromeHidden.registerCustomType('types.ChromeSetting', function() {
@@ -17,23 +18,23 @@ chromeHidden.registerCustomType('types.ChromeSetting', function() {
function ChromeSetting(prefKey, valueSchema) {
this.get = function(details, callback) {
- var getSchema = this.parameters.get;
- chromeHidden.validate([details, callback], getSchema);
+ var getSchema = this.functionSchemas.get.definition.parameters;
+ validate([details, callback], getSchema);
return sendRequest('types.ChromeSetting.get',
[prefKey, details, callback],
extendSchema(getSchema));
};
this.set = function(details, callback) {
- var setSchema = this.parameters.set.slice();
+ var setSchema = this.functionSchemas.set.definition.parameters.slice();
setSchema[0].properties.value = valueSchema;
- chromeHidden.validate([details, callback], setSchema);
+ validate([details, callback], setSchema);
return sendRequest('types.ChromeSetting.set',
[prefKey, details, callback],
extendSchema(setSchema));
};
this.clear = function(details, callback) {
- var clearSchema = this.parameters.clear;
- chromeHidden.validate([details, callback], clearSchema);
+ var clearSchema = this.functionSchemas.clear.definition.parameters;
+ validate([details, callback], clearSchema);
return sendRequest('types.ChromeSetting.clear',
[prefKey, details, callback],
extendSchema(clearSchema));

Powered by Google App Engine
This is Rietveld 408576698