Move creation and ownership of DownloadManager from the embedder to content. This matches all the o…

content/public/browser/download_manager.h

Index: content/public/browser/download_manager.h
===================================================================
--- content/public/browser/download_manager.h	(revision 140592)
+++ content/public/browser/download_manager.h	(working copy)
@@ -60,15 +60,15 @@
 class CONTENT_EXPORT DownloadManager
     : public base::RefCountedThreadSafe<DownloadManager> {
  public:
-  static DownloadManager* Create(
-      DownloadManagerDelegate* delegate,
-      net::NetLog* net_log);
-
   // A method that can be used in tests to ensure that all the internal download
   // classes have no pending downloads.
   static bool EnsureNoPendingDownloadsForTesting();
 
-  // Shutdown the download manager. Must be called before destruction.
+  // Sets the delegate for this DownloadManager. The delegate has to live past
+  // its Shutdown method being called.

[Randy Smith (Not in Mondays), 2012/06/06 15:51:59]

Which is under the control of the DownloadManager?  I don't see how the contract
is useful to the DM/Delegate interface unless there's also a guarantee that the
delegate's Shutdown method won't be called except by the DM, and the DM is
required to call it?

[jam, 2012/06/06 16:06:15]

I've clarified the comment to say that Shutdown is called by DM.

+  virtual void SetDelegate(DownloadManagerDelegate* delegate) = 0;

[tfarina, 2012/06/06 15:44:15]

There is already a SetDownloadManagerDelegate in this interface, see line 238

[jam, 2012/06/06 15:53:05]

thanks, I'll remove SetDownloadManagerDelegate 

+
+  // Shutdown the download manager. Called by content before destruction.
   virtual void Shutdown() = 0;
 
   // Interface to implement for observers that wish to be informed of changes