content/browser/renderer_host/resource_dispatcher_host_browsertest.cc - Issue 10535026: Move creation and ownership of DownloadManager from the embedder to content. This matches all the o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/resource_dispatcher_host_browsertest.cc

Issue 10535026: Move creation and ownership of DownloadManager from the embedder to content. This matches all the o… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix cros compile Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_context.cc ('K') | « content/browser/download/save_package.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | content/public/browser/browser_context.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/resource_dispatcher_host_browsertest.cc

===================================================================

--- content/browser/renderer_host/resource_dispatcher_host_browsertest.cc (revision 140592)

+++ content/browser/renderer_host/resource_dispatcher_host_browsertest.cc (working copy)

@@ -25,6 +25,7 @@

#include "net/url_request/url_request_context.h"

#include "net/url_request/url_request_context_getter.h"

+using content::BrowserContext;

using content::BrowserThread;

using content::DownloadManager;

@@ -190,7 +191,7 @@

IN_PROC_BROWSER_TEST_F(ResourceDispatcherHostBrowserTest,

SniffNoContentTypeNoData) {

// Make sure no downloads start.

- GetBrowserContext()->GetDownloadManager()->AddObserver(this);

+ BrowserContext::GetDownloadManager(GetBrowserContext())->AddObserver(this);

CheckTitleTest(GetMockURL("content-sniffer-test3.html"),

"Content Sniffer Test 3", 1);

EXPECT_EQ(1, browser()->tab_count());

@@ -248,7 +249,7 @@

IN_PROC_BROWSER_TEST_F(ResourceDispatcherHostBrowserTest,

SyncXMLHttpRequest_DuringUnload) {

ASSERT_TRUE(test_server()->Start());

- GetBrowserContext()->GetDownloadManager()->AddObserver(this);

+ BrowserContext::GetDownloadManager(GetBrowserContext())->AddObserver(this);

CheckTitleTest(

test_server()->GetURL("files/sync_xmlhttprequest_during_unload.html"),