Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: content/browser/download/download_manager_impl_unittest.cc

Issue 10535026: Move creation and ownership of DownloadManager from the embedder to content. This matches all the o… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix cros compile Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_manager_impl_unittest.cc
===================================================================
--- content/browser/download/download_manager_impl_unittest.cc (revision 140592)
+++ content/browser/download/download_manager_impl_unittest.cc (working copy)
@@ -104,21 +104,17 @@
class TestDownloadManagerDelegate : public content::DownloadManagerDelegate {
public:
- TestDownloadManagerDelegate()
+ explicit TestDownloadManagerDelegate(content::DownloadManager* dm)
: mark_content_dangerous_(false),
prompt_user_for_save_location_(false),
should_complete_download_(true),
- download_manager_(NULL) {
+ download_manager_(dm) {
}
void set_download_directory(const FilePath& path) {
download_directory_ = path;
}
- void set_download_manager(content::DownloadManager* dm) {
- download_manager_ = dm;
- }
-
void set_prompt_user_for_save_location(bool value) {
prompt_user_for_save_location_ = value;
}
@@ -262,13 +258,13 @@
DownloadManagerTest()
: browser_context(new content::TestBrowserContext()),
- download_manager_delegate_(new TestDownloadManagerDelegate()),
- download_manager_(new DownloadManagerImpl(
- download_manager_delegate_.get(), NULL)),
+ download_manager_(new DownloadManagerImpl(NULL)),
ui_thread_(BrowserThread::UI, &message_loop_),
file_thread_(BrowserThread::FILE, &message_loop_) {
+ download_manager_delegate_.reset(
+ new TestDownloadManagerDelegate(download_manager_.get()));
+ download_manager_->SetDelegate(download_manager_delegate_.get());
download_manager_->Init(browser_context.get());
- download_manager_delegate_->set_download_manager(download_manager_);
}
~DownloadManagerTest() {

Powered by Google App Engine
This is Rietveld 408576698