chrome/browser/ui/browser_close_browsertest.cc - Issue 10535026: Move creation and ownership of DownloadManager from the embedder to content. This matches all the o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_close_browsertest.cc

Issue 10535026: Move creation and ownership of DownloadManager from the embedder to content. This matches all the o… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix cros compile Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_service.cc ('K') | « chrome/browser/tab_contents/render_view_context_menu.cc ('k') | chrome/browser/ui/panels/panel_browsertest.cc » ('j') | content/browser/browser_context.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_close_browsertest.cc

===================================================================

--- chrome/browser/ui/browser_close_browsertest.cc (revision 140592)

+++ chrome/browser/ui/browser_close_browsertest.cc (working copy)

@@ -25,6 +25,7 @@

#include "content/public/common/page_transition_types.h"

#include "content/test/net/url_request_slow_download_job.h"

+using content::BrowserContext;

using content::BrowserThread;

using content::DownloadItem;

using content::DownloadManager;

@@ -112,7 +113,7 @@

// Setup an observer waiting for the given number of downloads

// to get to IN_PROGRESS.

DownloadManager* download_manager =

- browser->profile()->GetDownloadManager();

+ BrowserContext::GetDownloadManager(browser->profile());

scoped_ptr<DownloadTestObserver> observer(

new DownloadTestObserverInProgress(download_manager,

num_downloads,

@@ -146,7 +147,7 @@

DownloadService* download_service =

DownloadServiceFactory::GetForProfile(*pit);

if (download_service->HasCreatedDownloadManager()) {

- DownloadManager *mgr = download_service->GetDownloadManager();

+ DownloadManager *mgr = BrowserContext::GetDownloadManager(*pit);

scoped_refptr<DownloadTestFlushObserver> observer(

new DownloadTestFlushObserver(mgr));

observer->WaitForFlush();

@@ -156,8 +157,8 @@

DownloadServiceFactory::GetForProfile(

(*pit)->GetOffTheRecordProfile());

if (incognito_download_service->HasCreatedDownloadManager()) {

- DownloadManager *mgr =

- incognito_download_service->GetDownloadManager();

+ DownloadManager *mgr = BrowserContext::GetDownloadManager(

+ (*pit)->GetOffTheRecordProfile());

scoped_refptr<DownloadTestFlushObserver> observer(

new DownloadTestFlushObserver(mgr));

observer->WaitForFlush();