chrome/browser/download/download_extension_api.cc - Issue 10535026: Move creation and ownership of DownloadManager from the embedder to content. This matches all the o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_extension_api.cc

Issue 10535026: Move creation and ownership of DownloadManager from the embedder to content. This matches all the o… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix cros compile Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_browsertest.cc ('k') | chrome/browser/download/download_extension_test.cc » ('j') | chrome/browser/download/download_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_extension_api.cc

===================================================================

--- chrome/browser/download/download_extension_api.cc (revision 140592)

+++ chrome/browser/download/download_extension_api.cc (working copy)

@@ -47,6 +47,7 @@

#include "net/http/http_util.h"

#include "net/url_request/url_request.h"

+using content::BrowserContext;

using content::BrowserThread;

using content::DownloadId;

using content::DownloadItem;

@@ -313,12 +314,12 @@

Profile* profile,

bool include_incognito,

DownloadManager** manager, DownloadManager** incognito_manager) {

- *manager = DownloadServiceFactory::GetForProfile(profile)->

- GetDownloadManager();

+ *manager = BrowserContext::GetDownloadManager(profile);

*incognito_manager = NULL;

- if (include_incognito && profile->HasOffTheRecordProfile())

- *incognito_manager = DownloadServiceFactory::GetForProfile(profile->

- GetOffTheRecordProfile())->GetDownloadManager();

+ if (include_incognito && profile->HasOffTheRecordProfile()) {

+ *incognito_manager = BrowserContext::GetDownloadManager(

+ profile->GetOffTheRecordProfile());

+ }

}

DownloadItem* GetActiveItemInternal(