Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: chrome/browser/ui/webui/downloads_ui.cc

Issue 10535026: Move creation and ownership of DownloadManager from the embedder to content. This matches all the o… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix cros compile Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/downloads_ui.h" 5 #include "chrome/browser/ui/webui/downloads_ui.h"
6 6
7 #include "base/memory/ref_counted_memory.h" 7 #include "base/memory/ref_counted_memory.h"
8 #include "base/memory/singleton.h" 8 #include "base/memory/singleton.h"
9 #include "base/string_piece.h" 9 #include "base/string_piece.h"
10 #include "base/threading/thread.h" 10 #include "base/threading/thread.h"
11 #include "base/values.h" 11 #include "base/values.h"
12 #include "chrome/browser/defaults.h" 12 #include "chrome/browser/defaults.h"
13 #include "chrome/browser/download/download_service.h" 13 #include "chrome/browser/download/download_service.h"
14 #include "chrome/browser/download/download_service_factory.h" 14 #include "chrome/browser/download/download_service_factory.h"
15 #include "chrome/browser/profiles/profile.h" 15 #include "chrome/browser/profiles/profile.h"
16 #include "chrome/browser/ui/webui/chrome_url_data_manager.h" 16 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
17 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h" 17 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"
18 #include "chrome/browser/ui/webui/downloads_dom_handler.h" 18 #include "chrome/browser/ui/webui/downloads_dom_handler.h"
19 #include "chrome/common/url_constants.h" 19 #include "chrome/common/url_constants.h"
20 #include "content/public/browser/download_manager.h" 20 #include "content/public/browser/download_manager.h"
21 #include "content/public/browser/web_contents.h" 21 #include "content/public/browser/web_contents.h"
22 #include "content/public/browser/web_ui.h" 22 #include "content/public/browser/web_ui.h"
23 #include "grit/browser_resources.h" 23 #include "grit/browser_resources.h"
24 #include "grit/generated_resources.h" 24 #include "grit/generated_resources.h"
25 #include "grit/theme_resources.h" 25 #include "grit/theme_resources.h"
26 #include "grit/theme_resources_standard.h" 26 #include "grit/theme_resources_standard.h"
27 #include "ui/base/layout.h" 27 #include "ui/base/layout.h"
28 #include "ui/base/resource/resource_bundle.h" 28 #include "ui/base/resource/resource_bundle.h"
29 29
30 using content::BrowserContext;
30 using content::DownloadManager; 31 using content::DownloadManager;
31 using content::WebContents; 32 using content::WebContents;
32 33
33 namespace { 34 namespace {
34 35
35 ChromeWebUIDataSource* CreateDownloadsUIHTMLSource() { 36 ChromeWebUIDataSource* CreateDownloadsUIHTMLSource() {
36 ChromeWebUIDataSource* source = 37 ChromeWebUIDataSource* source =
37 new ChromeWebUIDataSource(chrome::kChromeUIDownloadsHost); 38 new ChromeWebUIDataSource(chrome::kChromeUIDownloadsHost);
38 39
39 source->AddLocalizedString("title", IDS_DOWNLOAD_TITLE); 40 source->AddLocalizedString("title", IDS_DOWNLOAD_TITLE);
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 } // namespace 83 } // namespace
83 84
84 /////////////////////////////////////////////////////////////////////////////// 85 ///////////////////////////////////////////////////////////////////////////////
85 // 86 //
86 // DownloadsUI 87 // DownloadsUI
87 // 88 //
88 /////////////////////////////////////////////////////////////////////////////// 89 ///////////////////////////////////////////////////////////////////////////////
89 90
90 DownloadsUI::DownloadsUI(content::WebUI* web_ui) : WebUIController(web_ui) { 91 DownloadsUI::DownloadsUI(content::WebUI* web_ui) : WebUIController(web_ui) {
91 Profile* profile = Profile::FromWebUI(web_ui); 92 Profile* profile = Profile::FromWebUI(web_ui);
92 DownloadManager* dlm = 93 DownloadManager* dlm = BrowserContext::GetDownloadManager(profile);
93 DownloadServiceFactory::GetForProfile(profile)->GetDownloadManager();
94 94
95 DownloadsDOMHandler* handler = new DownloadsDOMHandler(dlm); 95 DownloadsDOMHandler* handler = new DownloadsDOMHandler(dlm);
96 web_ui->AddMessageHandler(handler); 96 web_ui->AddMessageHandler(handler);
97 97
98 // Set up the chrome://downloads/ source. 98 // Set up the chrome://downloads/ source.
99 ChromeWebUIDataSource* source = CreateDownloadsUIHTMLSource(); 99 ChromeWebUIDataSource* source = CreateDownloadsUIHTMLSource();
100 source->set_use_json_js_format_v2(); 100 source->set_use_json_js_format_v2();
101 ChromeURLDataManager::AddDataSource(profile, source); 101 ChromeURLDataManager::AddDataSource(profile, source);
102 } 102 }
103 103
104 // static 104 // static
105 base::RefCountedMemory* DownloadsUI::GetFaviconResourceBytes() { 105 base::RefCountedMemory* DownloadsUI::GetFaviconResourceBytes() {
106 return ResourceBundle::GetSharedInstance(). 106 return ResourceBundle::GetSharedInstance().
107 LoadDataResourceBytes(IDR_DOWNLOADS_FAVICON, 107 LoadDataResourceBytes(IDR_DOWNLOADS_FAVICON,
108 ui::SCALE_FACTOR_NONE); 108 ui::SCALE_FACTOR_NONE);
109 } 109 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698