Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 10535022: Re-enable gtalk test. (Closed)

Created:
8 years, 6 months ago by krenaud
Modified:
8 years, 6 months ago
Reviewers:
craigdh, Nirnimesh
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1
Visibility:
Public.

Description

Re-enable gtalk test. Wait until mole content loads before trying to disable extension. Test was occasionally hitting errors when disabling the extension because it could not get the window. BUG=128563 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141153

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/test/functional/PYAUTO_TESTS View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/functional/gtalk/test_basic.py View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
krenaud
Re-adding gtalk pyauto test to suite.
8 years, 6 months ago (2012-06-05 22:09:38 UTC) #1
Nirnimesh
Are you sure the problems have been fixed now? The test was very flaky when ...
8 years, 6 months ago (2012-06-05 23:58:36 UTC) #2
krenaud
On 2012/06/05 23:58:36, Nirnimesh wrote: > Are you sure the problems have been fixed now? ...
8 years, 6 months ago (2012-06-06 00:18:10 UTC) #3
Nirnimesh
I'm fine if you want to try on the bots again. LGTM.
8 years, 6 months ago (2012-06-06 00:29:27 UTC) #4
craigdh
lgtm, but let's keep an eye on it and revert if it starts flaking.
8 years, 6 months ago (2012-06-06 00:35:38 UTC) #5
krenaud
Made small change to the test. This seems to fix the flakiness issue. Please review.
8 years, 6 months ago (2012-06-07 18:12:03 UTC) #6
Nirnimesh
Sleep is a bad idea. While it might seem to fix flakiness, it's no guarantee ...
8 years, 6 months ago (2012-06-07 18:16:52 UTC) #7
krenaud
Agreed. What this sleep was actually doing was giving time for the window to fully ...
8 years, 6 months ago (2012-06-07 18:27:08 UTC) #8
Nirnimesh
LGTM
8 years, 6 months ago (2012-06-07 18:40:20 UTC) #9
craigdh
lgtm, thanks for fixing the source of the flakiness.
8 years, 6 months ago (2012-06-07 18:41:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/krenaud@google.com/10535022/7001
8 years, 6 months ago (2012-06-07 18:41:45 UTC) #11
commit-bot: I haz the power
Try job failure for 10535022-7001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-06-07 20:28:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/krenaud@google.com/10535022/7001
8 years, 6 months ago (2012-06-08 00:36:26 UTC) #13
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 01:52:01 UTC) #14
Change committed as 141153

Powered by Google App Engine
This is Rietveld 408576698