Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 10535018: Don't pass GSS_C_NO_CONTEXT into gss_inquire_context() (Closed)

Created:
8 years, 6 months ago by asanka
Modified:
8 years, 6 months ago
Reviewers:
cbentzel
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Don't pass GSS_C_NO_CONTEXT into gss_inquire_context() If the call to gss_init_sec_context() failed, the returned context handle could be NULL. Attempting to describe the context by calling gss_inquire_context() using the NULL handle can cause a crash in the Kerberos library. BUG=73145 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M net/http/http_auth_gssapi_posix.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
asanka
8 years, 6 months ago (2012-06-05 19:33:48 UTC) #1
cbentzel
LGTM Always a sad day when logging is the cause of crashes.
8 years, 6 months ago (2012-06-05 19:57:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/10535018/1
8 years, 6 months ago (2012-06-05 20:02:39 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-05 20:47:36 UTC) #4
Change committed as 140603

Powered by Google App Engine
This is Rietveld 408576698