Issue 10535011: Remove one more case behind --es5_readonly flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10535011: Remove one more case behind --es5_readonly flag. (Closed)

Created:
8 years, 6 months ago by rossberg

Modified:
8 years, 6 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove one more case behind --es5_readonly flag. Plus add a couple of assertions. R=mstarzinger@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11719

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed Michael's comment. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
M	src/hydrogen.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/mjsunit/with-readonly.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 6 months ago (2012-06-05 16:51:14 UTC) #2

LGTM (if one nit is addressed).

https://chromiumcodereview.appspot.com/10535011/diff/1/src/objects.cc
File src/objects.cc (right):

https://chromiumcodereview.appspot.com/10535011/diff/1/src/objects.cc#newcode...
src/objects.cc:2555: ASSERT(result->type() != INTERCEPTOR);
Can we move that out of into one line doing just the assertion. Like this:

ASSERT(!result->IsProperty() || result->type() != INTERCEPTOR);

Expand Messages | Collapse Messages