Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 10535007: Put inherited readonliness behind a flag, (Closed)

Created:
8 years, 6 months ago by rossberg
Modified:
8 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Put inherited readonliness behind a flag, since it currently breaks WebKit bindings massively. R=mstarzinger@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11714

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/override-read-only-property.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/readonly.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
rossberg
8 years, 6 months ago (2012-06-05 12:33:23 UTC) #1
Michael Starzinger
8 years, 6 months ago (2012-06-05 12:37:58 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698