Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: src/objects.cc

Issue 10535004: ClearNonLiveTransitions has to hold on to non-map values. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/accessor-map-sharing.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 1544836fe3bac3c4e796f1abd22d9b1a74874eec..4133f97cae7f79018b2e2eb3e0d6b4c6a031e52d 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -7399,7 +7399,10 @@ void String::PrintOn(FILE* file) {
// Return true in case a back pointer has been cleared and false otherwise.
// Set *keep_entry to true when a live map transition has been found.
static bool ClearBackPointer(Heap* heap, Object* target, bool* keep_entry) {
- if (!target->IsMap()) return false;
+ if (!target->IsMap()) {
+ *keep_entry = true;
Michael Starzinger 2012/06/05 09:12:48 I don't think this fix is completely correct, beca
Toon Verwaest 2012/06/05 10:29:16 Done.
+ return false;
+ }
Map* map = Map::cast(target);
if (Marking::MarkBitFrom(map).Get()) {
*keep_entry = true;
« no previous file with comments | « no previous file | test/mjsunit/accessor-map-sharing.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698