Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: gpu/command_buffer/service/program_manager_unittest.cc

Issue 10534173: GPU Program Caching (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: solid in-memory implementation Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/program_manager_unittest.cc
diff --git a/gpu/command_buffer/service/program_manager_unittest.cc b/gpu/command_buffer/service/program_manager_unittest.cc
index c0fad679a4a97da74c57c38beba93a50372670a4..a350678506ee906d69f2bb4377de804bf6c30043 100644
--- a/gpu/command_buffer/service/program_manager_unittest.cc
+++ b/gpu/command_buffer/service/program_manager_unittest.cc
@@ -7,6 +7,7 @@
#include <algorithm>
#include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
#include "base/string_number_conversions.h"
#include "base/string_util.h"
#include "gpu/command_buffer/common/gl_mock.h"
@@ -31,10 +32,11 @@ using ::testing::StrictMock;
namespace gpu {
namespace gles2 {
+class ProgramCache;
class ProgramManagerTest : public testing::Test {
public:
- ProgramManagerTest() { }
+ ProgramManagerTest() : manager_(base::WeakPtr<ProgramCache>()) { }
~ProgramManagerTest() {
manager_.Destroy(false);
}
@@ -144,7 +146,7 @@ TEST_F(ProgramManagerTest, SwizzleLocation) {
class ProgramManagerWithShaderTest : public testing::Test {
public:
ProgramManagerWithShaderTest()
- : program_info_(NULL) {
+ : manager_(base::WeakPtr<ProgramCache>()), program_info_(NULL) {
}
~ProgramManagerWithShaderTest() {
@@ -225,7 +227,7 @@ class ProgramManagerWithShaderTest : public testing::Test {
program_info_->AttachShader(&shader_manager_, vertex_shader);
program_info_->AttachShader(&shader_manager_, fragment_shader);
- program_info_->Link();
+ program_info_->Link(NULL, NULL, NULL, NULL);
}
void SetupShader(AttribInfo* attribs, size_t num_attribs,
@@ -258,7 +260,7 @@ class ProgramManagerWithShaderTest : public testing::Test {
SetupShader(kAttribs, kNumAttribs, kUniforms, kNumUniforms,
service_id);
}
- program_info->Link();
+ program_info->Link(NULL, NULL, NULL, NULL);
GLint link_status;
program_info->GetProgramiv(GL_LINK_STATUS, &link_status);
return (static_cast<bool>(link_status) == expected_link_status);
@@ -585,7 +587,7 @@ TEST_F(ProgramManagerWithShaderTest, GLDriverReturnsGLUnderscoreUniform) {
ASSERT_TRUE(program_info != NULL);
EXPECT_TRUE(program_info->AttachShader(&shader_manager_, vshader));
EXPECT_TRUE(program_info->AttachShader(&shader_manager_, fshader));
- program_info->Link();
+ program_info->Link(NULL, NULL, NULL, NULL);
GLint value = 0;
program_info->GetProgramiv(GL_ACTIVE_ATTRIBUTES, &value);
EXPECT_EQ(3, value);
@@ -676,7 +678,7 @@ TEST_F(ProgramManagerWithShaderTest, GLDriverReturnsWrongTypeInfo) {
ASSERT_TRUE(program_info != NULL);
EXPECT_TRUE(program_info->AttachShader(&shader_manager_, vshader));
EXPECT_TRUE(program_info->AttachShader(&shader_manager_, fshader));
- program_info->Link();
+ program_info->Link(NULL, NULL, NULL, NULL);
// Check that we got the good type, not the bad.
// Check Attribs
for (unsigned index = 0; index < kNumAttribs; ++index) {
@@ -993,7 +995,7 @@ TEST_F(ProgramManagerWithShaderTest, ClearWithSamplerTypes) {
const size_t kNumUniforms = arraysize(kUniforms);
SetupShader(kAttribs, kNumAttribs, kUniforms, kNumUniforms,
kServiceProgramId);
- program_info->Link();
+ program_info->Link(NULL, NULL, NULL, NULL);
SetupExpectationsForClearingUniforms(kUniforms, kNumUniforms);
manager_.ClearUniforms(program_info);
}

Powered by Google App Engine
This is Rietveld 408576698