Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10534172: Implement ISO BMFF support in Media Source (try 2). (Closed)

Created:
8 years, 6 months ago by strobe_
Modified:
8 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Implement ISO BMFF support in Media Source (try 2). Previous review: https://chromiumcodereview.appspot.com/10536014/ BUG=129072 TEST=MP4StreamParserTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142409

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3193 lines, -0 lines) Patch
M media/filters/chunk_demuxer.cc View 3 chunks +23 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M media/media.gyp View 3 chunks +19 lines, -0 lines 0 comments Download
A media/mp4/avc.h View 1 chunk +34 lines, -0 lines 0 comments Download
A media/mp4/avc.cc View 1 chunk +114 lines, -0 lines 0 comments Download
A media/mp4/avc_unittest.cc View 1 chunk +96 lines, -0 lines 0 comments Download
A media/mp4/box_definitions.h View 1 chunk +330 lines, -0 lines 0 comments Download
A media/mp4/box_definitions.cc View 1 chunk +638 lines, -0 lines 0 comments Download
A media/mp4/box_reader.h View 1 chunk +201 lines, -0 lines 0 comments Download
A media/mp4/box_reader.cc View 1 chunk +193 lines, -0 lines 0 comments Download
A media/mp4/box_reader_unittest.cc View 1 chunk +182 lines, -0 lines 0 comments Download
A media/mp4/cenc.h View 1 chunk +36 lines, -0 lines 0 comments Download
A media/mp4/cenc.cc View 1 chunk +45 lines, -0 lines 0 comments Download
A media/mp4/fourccs.h View 1 chunk +98 lines, -0 lines 0 comments Download
A media/mp4/mp4_stream_parser.h View 1 chunk +97 lines, -0 lines 0 comments Download
A media/mp4/mp4_stream_parser.cc View 1 chunk +341 lines, -0 lines 0 comments Download
A media/mp4/mp4_stream_parser_unittest.cc View 1 chunk +114 lines, -0 lines 0 comments Download
A media/mp4/offset_byte_queue.h View 1 chunk +66 lines, -0 lines 0 comments Download
A media/mp4/offset_byte_queue.cc View 1 chunk +63 lines, -0 lines 0 comments Download
A media/mp4/offset_byte_queue_unittest.cc View 1 chunk +96 lines, -0 lines 0 comments Download
A media/mp4/rcheck.h View 1 chunk +18 lines, -0 lines 0 comments Download
A media/mp4/track_run_iterator.h View 1 chunk +118 lines, -0 lines 0 comments Download
A media/mp4/track_run_iterator.cc View 1 chunk +263 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
strobe_
Sorry for the fuss. https://chromiumcodereview.appspot.com/10534172/diff/1/media/mp4/track_run_iterator.cc File media/mp4/track_run_iterator.cc (right): https://chromiumcodereview.appspot.com/10534172/diff/1/media/mp4/track_run_iterator.cc#newcode16 media/mp4/track_run_iterator.cc:16: DCHECK_LT((numer > 0 ? numer ...
8 years, 6 months ago (2012-06-15 00:41:50 UTC) #1
acolwell GONE FROM CHROMIUM
LGTM
8 years, 6 months ago (2012-06-15 01:06:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/strobe@google.com/10534172/1
8 years, 6 months ago (2012-06-15 15:55:58 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-15 17:00:07 UTC) #4 
Change committed as 142409

Powered by Google App Engine
This is Rietveld 408576698