chrome/common/automation_messages_internal.h - Issue 10534163: First pass at refactoring pyautolib in preparation for removing proxy dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/automation_messages_internal.h

Issue 10534163: First pass at refactoring pyautolib in preparation for removing proxy dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Previous commit was reverted. Changed IPCs to be backwards compatible with old chrome binaries. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/automation/testing_automation_provider.cc ('k') | chrome/test/automation/automation_json_requests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/automation_messages_internal.h

diff --git a/chrome/common/automation_messages_internal.h b/chrome/common/automation_messages_internal.h

index ce767cc702a5d25f8569ceed5869fc1e1e55f9c6..9073ada8a538f9397f0f831b0fc66c4059262f8d 100644

--- a/chrome/common/automation_messages_internal.h

+++ b/chrome/common/automation_messages_internal.h

@@ -856,7 +856,7 @@ IPC_MESSAGE_CONTROL1(AutomationMsg_RemoveBrowsingData,

// Generic pyauto pattern to help avoid future addition of

// automation messages.

-IPC_SYNC_MESSAGE_CONTROL2_2(AutomationMsg_SendJSONRequest,

+IPC_SYNC_MESSAGE_CONTROL2_2(AutomationMsg_SendJSONRequestWithBrowserHandle,

int /* browser_handle */,

std::string /* JSON request */,

std::string /* JSON response */,

@@ -950,6 +950,14 @@ IPC_SYNC_MESSAGE_CONTROL0_2(AutomationMsg_GetTracingOutput,

IPC_SYNC_MESSAGE_CONTROL0_1(AutomationMsg_GetMachPortCount,

int /* number of Mach ports */)

+// Generic pyauto pattern to help avoid future addition of

+// automation messages.

+IPC_SYNC_MESSAGE_CONTROL2_2(AutomationMsg_SendJSONRequest,

+ int /* window_index */,

+ std::string /* JSON request */,

+ std::string /* JSON response */,

+ bool /* success */)

// Browser -> renderer messages.

// Requests a snapshot.

« no previous file with comments | « chrome/browser/automation/testing_automation_provider.cc ('k') | chrome/test/automation/automation_json_requests.cc » ('j') | no next file with comments »