Implement fileSystem.chooseFile.

Implement fileSystem.chooseFile.

This allows platform apps to prompt the user for a file to read or a file to
write. If opening (reading) the file entry returned will be read only. If
saving the file entry will be read write.

BUG=130196
TEST=Manual testing


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142314

[koz (OOO until 15th September), 2012-06-14 06:18:01]

lgtm

extensions lgtm

http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/a...
File chrome/browser/extensions/api/file_system/file_system_api.cc (right):

http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/a...
chrome/browser/extensions/api/file_system/file_system_api.cc:77: bool created =
false;
This doesn't seem to be used, so you can remove it and pass NULL below.

http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/a...
chrome/browser/extensions/api/file_system/file_system_api.cc:155: bool
for_save_;
Could you add a comment here?

http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/a...
File chrome/browser/extensions/api/file_system/file_system_api.h (right):

http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/a...
chrome/browser/extensions/api/file_system/file_system_api.h:34: //
CheckWritableFile is called on the FILE thread. This is only called when a
You can probably omit the first two words of this comment. (Here and elsewhere
in this file.)

[kinuko, 2012-06-14 06:32:33]

lgtm

On 2012/06/14 06:18:01, koz wrote:
> lgtm
> 
> extensions lgtm
> 
>
http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/a...
> File chrome/browser/extensions/api/file_system/file_system_api.cc (right):
> 
>
http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/a...
> chrome/browser/extensions/api/file_system/file_system_api.cc:77: bool created
=
> false;
> This doesn't seem to be used, so you can remove it and pass NULL below.
> 
>
http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/a...
> chrome/browser/extensions/api/file_system/file_system_api.cc:155: bool
> for_save_;
> Could you add a comment here?
> 
>
http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/a...
> File chrome/browser/extensions/api/file_system/file_system_api.h (right):
> 
>
http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/a...
> chrome/browser/extensions/api/file_system/file_system_api.h:34: //
> CheckWritableFile is called on the FILE thread. This is only called when a
> You can probably omit the first two words of this comment. (Here and elsewhere
> in this file.)

[benwells, 2012-06-15 00:45:44]

http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/a...
File chrome/browser/extensions/api/file_system/file_system_api.cc (right):

http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/a...
chrome/browser/extensions/api/file_system/file_system_api.cc:77: bool created =
false;
On 2012/06/14 06:18:01, koz wrote:
> This doesn't seem to be used, so you can remove it and pass NULL below.

Done. I also changed from CREATE_ALWAYS to CREATE, CREATE_ALWAYS is not needed.

http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/a...
chrome/browser/extensions/api/file_system/file_system_api.cc:155: bool
for_save_;
On 2012/06/14 06:18:01, koz wrote:
> Could you add a comment here?

Done.

http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/a...
File chrome/browser/extensions/api/file_system/file_system_api.h (right):

http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/a...
chrome/browser/extensions/api/file_system/file_system_api.h:34: //
CheckWritableFile is called on the FILE thread. This is only called when a
On 2012/06/14 06:18:01, koz wrote:
> You can probably omit the first two words of this comment. (Here and elsewhere
> in this file.)

Done.

[commit-bot: I haz the power, 2012-06-15 00:46:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/10534156/8001

[commit-bot: I haz the power, 2012-06-15 01:58:27]

Change committed as 142314

[Mihai Parparita -not on Chrome, 2012-06-15 04:19:15]

http://codereview.chromium.org/10534156/diff/8001/chrome/browser/extensions/a...
File chrome/browser/extensions/api/file_system/file_system_api.cc (right):

http://codereview.chromium.org/10534156/diff/8001/chrome/browser/extensions/a...
chrome/browser/extensions/api/file_system/file_system_api.cc:276: if
(options->type.get() &&  *options->type == kSaveFileOption)
Nit: extra space before the *