Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 10534156: Implement fileSystem.chooseFile. (Closed)

Created:
8 years, 6 months ago by benwells
Modified:
8 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, kinuko+watch, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Implement fileSystem.chooseFile. This allows platform apps to prompt the user for a file to read or a file to write. If opening (reading) the file entry returned will be read only. If saving the file entry will be read write. BUG=130196 TEST=Manual testing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142314

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 6

Patch Set 3 : Review feedback #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -54 lines) Patch
M chrome/browser/extensions/api/file_system/file_system_api.h View 1 2 1 chunk +34 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 1 2 10 chunks +116 lines, -26 lines 1 comment Download
M chrome/common/extensions/api/file_system.idl View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/file_system_custom_bindings.js View 1 chunk +24 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
benwells
8 years, 6 months ago (2012-06-14 05:14:41 UTC) #1
koz (OOO until 15th September)
lgtm extensions lgtm http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/api/file_system/file_system_api.cc File chrome/browser/extensions/api/file_system/file_system_api.cc (right): http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/api/file_system/file_system_api.cc#newcode77 chrome/browser/extensions/api/file_system/file_system_api.cc:77: bool created = false; This doesn't ...
8 years, 6 months ago (2012-06-14 06:18:01 UTC) #2
kinuko
lgtm On 2012/06/14 06:18:01, koz wrote: > lgtm > > extensions lgtm > > http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/api/file_system/file_system_api.cc ...
8 years, 6 months ago (2012-06-14 06:32:33 UTC) #3
benwells
http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/api/file_system/file_system_api.cc File chrome/browser/extensions/api/file_system/file_system_api.cc (right): http://codereview.chromium.org/10534156/diff/2001/chrome/browser/extensions/api/file_system/file_system_api.cc#newcode77 chrome/browser/extensions/api/file_system/file_system_api.cc:77: bool created = false; On 2012/06/14 06:18:01, koz wrote: ...
8 years, 6 months ago (2012-06-15 00:45:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10534156/8001
8 years, 6 months ago (2012-06-15 00:46:15 UTC) #5
commit-bot: I haz the power
Change committed as 142314
8 years, 6 months ago (2012-06-15 01:58:27 UTC) #6
Mihai Parparita -not on Chrome
8 years, 6 months ago (2012-06-15 04:19:15 UTC) #7
http://codereview.chromium.org/10534156/diff/8001/chrome/browser/extensions/a...
File chrome/browser/extensions/api/file_system/file_system_api.cc (right):

http://codereview.chromium.org/10534156/diff/8001/chrome/browser/extensions/a...
chrome/browser/extensions/api/file_system/file_system_api.cc:276: if
(options->type.get() &&  *options->type == kSaveFileOption)
Nit: extra space before the *

Powered by Google App Engine
This is Rietveld 408576698