Issue 10534148: Better logging in extension update code for case of invalid crx urls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10534148: Better logging in extension update code for case of invalid crx urls (Closed)

Created:
8 years, 6 months ago by asargent_no_longer_on_chrome

Modified:
8 years, 6 months ago

Reviewers:
Mihai Parparita -not on Chrome

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Better logging in extension update code for case of invalid crx urls It turns out that calling .spec() on an invalid url just returns the empty string (and causes a DCHECK failure). BUG=130881 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142058

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/extensions/updater/extension_downloader.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/10534148/1

8 years, 6 months ago (2012-06-13 19:41:26 UTC) #3

commit-bot: I haz the power

Try job failure for 10534148-1 (retry) on linux_clang for step "compile" (clobber build). It's a ...

8 years, 6 months ago (2012-06-13 20:07:57 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/10534148/1

8 years, 6 months ago (2012-06-14 00:12:25 UTC) #5

Change committed as 142058

Expand Messages | Collapse Messages