Add support for pinning platform apps

Add support for pinning platform apps


BUG=131878
TEST=Existing and new LauncherPlatformAppBrowserTest

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142086

[sky, 2012-06-13 21:20:53]

https://chromiumcodereview.appspot.com/10534142/diff/2001/ash/launcher/launch...
File ash/launcher/launcher_model.cc (right):

https://chromiumcodereview.appspot.com/10534142/diff/2001/ash/launcher/launch...
ash/launcher/launcher_model.cc:101: int new_index =
ValidateInsertionIndex(items_[index].type, index);
By updating the item then validating you've broken the ordering. I don't think
ValidateInsertionIndex will behave reliably in this situation.

https://chromiumcodereview.appspot.com/10534142/diff/2001/chrome/browser/ui/v...
File chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc (right):

https://chromiumcodereview.appspot.com/10534142/diff/2001/chrome/browser/ui/v...
chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc:219:
model_->Set(index, item);
Are we picking up the type right for these when they get restored?

[DaveMoore, 2012-06-13 22:30:15]

https://chromiumcodereview.appspot.com/10534142/diff/2001/ash/launcher/launch...
File ash/launcher/launcher_model.cc (right):

https://chromiumcodereview.appspot.com/10534142/diff/2001/ash/launcher/launch...
ash/launcher/launcher_model.cc:101: int new_index =
ValidateInsertionIndex(items_[index].type, index);
On 2012/06/13 21:20:53, sky wrote:
> By updating the item then validating you've broken the ordering. I don't think
> ValidateInsertionIndex will behave reliably in this situation.

Done.

https://chromiumcodereview.appspot.com/10534142/diff/2001/chrome/browser/ui/v...
File chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc (right):

https://chromiumcodereview.appspot.com/10534142/diff/2001/chrome/browser/ui/v...
chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc:219:
model_->Set(index, item);
I believe so. We only persist shortcuts, not the apps themselves.

On 2012/06/13 21:20:53, sky wrote:
> Are we picking up the type right for these when they get restored?

[sky, 2012-06-13 23:43:27]

LGTM

https://chromiumcodereview.appspot.com/10534142/diff/9002/ash/launcher/launch...
File ash/launcher/launcher_model.cc (right):

https://chromiumcodereview.appspot.com/10534142/diff/9002/ash/launcher/launch...
ash/launcher/launcher_model.cc:104: Move(index, new_index);
nit: spacing is off.