Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: chrome/browser/chromeos/input_method/candidate_window_view.h

Issue 10534134: Fix candidate window position issue. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix braces Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/candidate_window_view.h
diff --git a/chrome/browser/chromeos/input_method/candidate_window_view.h b/chrome/browser/chromeos/input_method/candidate_window_view.h
index 5d69c750ba9783e9948dceccbd30cf042313f569..ab6b42397494562b87dd9fc822f3593deabb8067 100644
--- a/chrome/browser/chromeos/input_method/candidate_window_view.h
+++ b/chrome/browser/chromeos/input_method/candidate_window_view.h
@@ -131,7 +131,15 @@ class CandidateWindowView : public views::View {
cursor_location_ = cursor_location;
}
+ void set_composition_head_location(
+ const gfx::Rect& composition_head_location) {
+ composition_head_location_ = composition_head_location;
+ }
+
const gfx::Rect& cursor_location() const { return cursor_location_; }
+ const gfx::Rect& composition_head_location() const {
+ return composition_head_location_;
+ }
protected:
// Override View::VisibilityChanged()
@@ -201,15 +209,12 @@ class CandidateWindowView : public views::View {
// The last cursor location.
gfx::Rect cursor_location_;
- // This location is used by suggestion window rendering which is mostly used
- // by ibus-mozc. The suggestion window should be aligned with the composition
- // text as opposed to the cursor. In case of ibus-mozc, suggestion window
- // location is calculated by engine and it carried by update_lookup_table
- // signal as additional information. This value is available when
- // is_suggestion_window_available is true.
- gfx::Rect suggestion_window_location_;
+ // The last compostion head location.
+ gfx::Rect composition_head_location_;
- bool is_suggestion_window_location_available_;
+ // True if the candidate window should be shown with aligning with composition
+ // text as opposed to the cursor.
+ bool should_show_at_composition_head_;
// True if the candidate window should be shonw on the upper side of
// composition text.

Powered by Google App Engine
This is Rietveld 408576698