Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: net/proxy/proxy_script_decider.h

Issue 10534132: NetLogEventParameter to Callback refactoring 7. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Remove unneeded variable Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/proxy_resolver_js_bindings.cc ('k') | net/proxy/proxy_script_decider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_script_decider.h
===================================================================
--- net/proxy/proxy_script_decider.h (revision 141995)
+++ net/proxy/proxy_script_decider.h (working copy)
@@ -6,6 +6,7 @@
#define NET_PROXY_PROXY_SCRIPT_DECIDER_H_
#pragma once
+#include <string>
#include <vector>
#include "base/memory/ref_counted.h"
@@ -89,6 +90,12 @@
PacSource(Type type, const GURL& url)
: type(type), url(url) {}
+ // Returns a Value representing the PacSource. |effective_pac_url| must
+ // be non-NULL and point to the URL derived from information contained in
+ // |this|, if Type is not WPAD_DHCP.
+ base::Value* NetLogCallback(const GURL* effective_pac_url,
+ NetLog::LogLevel log_level) const;
+
Type type;
GURL url; // Empty unless |type == PAC_SOURCE_CUSTOM|.
};
@@ -131,8 +138,7 @@
// ProxyResolver doesn't |expect_pac_bytes()|.
State GetStartState() const;
- NetLogStringParameter* CreateNetLogParameterAndDetermineURL(
- const PacSource& pac_source, GURL* effective_pac_url);
+ void DetermineURL(const PacSource& pac_source, GURL* effective_pac_url);
// Returns the current PAC URL we are fetching/testing.
const PacSource& current_pac_source() const;
« no previous file with comments | « net/proxy/proxy_resolver_js_bindings.cc ('k') | net/proxy/proxy_script_decider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698