chrome/common/extensions/event_filtering_info.h - Issue 10534125: Extend EventFilter to handle the case where EventMatchers from event X get

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/event_filtering_info.h

Issue 10534125: Extend EventFilter to handle the case where EventMatchers from event X get (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: respond to comments Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/event_filter.h ('K') | « chrome/common/extensions/event_filter_unittest.cc ('k') | chrome/common/extensions/event_filtering_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/event_filtering_info.h

diff --git a/chrome/common/extensions/event_filtering_info.h b/chrome/common/extensions/event_filtering_info.h

index e7077f1ba89bb213946d9a06349befbd6819a970..044797229eb87cbb78cedc1b1f4d18e78a3fb308 100644

--- a/chrome/common/extensions/event_filtering_info.h

+++ b/chrome/common/extensions/event_filtering_info.h

@@ -27,11 +27,11 @@ class EventFilteringInfo {

bool has_url() const { return has_url_; }

const GURL& url() const { return url_; }

+ std::string AsJSONString() const;

private:

bool has_url_;

GURL url_;

- DISALLOW_COPY_AND_ASSIGN(EventFilteringInfo);

battre 2012/06/13 09:22:04 Can you add a comment "// Allow implicit copy and

koz (OOO until 15th September) 2012/06/14 02:22:25 Done.

};

} // namespace extensions