Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1326)

Unified Diff: content/browser/geolocation/device_data_provider.h

Issue 10534120: Remove RadioData from geolocation (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: fix content_unittests Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/geolocation/device_data_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/geolocation/device_data_provider.h
diff --git a/content/browser/geolocation/device_data_provider.h b/content/browser/geolocation/device_data_provider.h
index 2951f70c72a2ac66a37fc24202afd966d4ec4248..5c89d6d021f22319aa172356f91547ea1561f708 100644
--- a/content/browser/geolocation/device_data_provider.h
+++ b/content/browser/geolocation/device_data_provider.h
@@ -23,9 +23,7 @@
#define CONTENT_BROWSER_GEOLOCATION_DEVICE_DATA_PROVIDER_H_
#pragma once
-#include <algorithm>
#include <set>
-#include <vector>
#include "base/basictypes.h"
#include "base/bind.h"
@@ -36,65 +34,6 @@
#include "base/threading/non_thread_safe.h"
#include "content/common/content_export.h"
-// The following data structures are used to store cell radio data and wifi
-// data. See the Geolocation API design document at
-// http://code.google.com/p/google-gears/wiki/LocationAPI for a more complete
-// description.
-//
-// For all integer fields, we use kint32min to represent unknown values.
-
-// Cell radio data relating to a single cell tower.
-struct CellData {
- CellData();
- bool Matches(const CellData &other) const {
- // Ignore radio_signal_strength when matching.
- return cell_id == other.cell_id &&
- location_area_code == other.location_area_code &&
- mobile_network_code == other.mobile_network_code &&
- mobile_country_code == other.mobile_country_code &&
- timing_advance == other.timing_advance;
- }
-
- int cell_id; // Unique identifier of the cell
- int location_area_code; // For current location area
- int mobile_network_code; // For current cell
- int mobile_country_code; // For current cell
- int radio_signal_strength; // Measured in dBm.
- int timing_advance; // Timing advance representing the distance from
- // the cell tower. Each unit is roughly 550
- // meters.
-};
-
-enum RadioType {
- RADIO_TYPE_UNKNOWN,
- RADIO_TYPE_GSM,
- RADIO_TYPE_CDMA,
- RADIO_TYPE_WCDMA,
-};
-
-// All data for the cell radio.
-// TODO(joth): Remove RadioData and all usage of it; http://crbug.com/103713
-struct CONTENT_EXPORT RadioData {
- RadioData();
- ~RadioData();
-
- bool Matches(const RadioData &other) const;
-
- // Determines whether a new set of radio data differs significantly from this.
- bool DiffersSignificantly(const RadioData &other) const {
- // This is required by MockDeviceDataProviderImpl.
- // TODO(steveblock): Implement properly.
- return !Matches(other);
- }
-
- string16 device_id;
- std::vector<CellData> cell_data;
- int home_mobile_network_code; // For the device's home network.
- int home_mobile_country_code; // For the device's home network.
- RadioType radio_type; // Mobile radio type.
- string16 carrier; // Carrier name.
-};
-
// Wifi data relating to a single access point.
struct CONTENT_EXPORT AccessPointData {
AccessPointData();
@@ -231,7 +170,6 @@ class DeviceDataProviderImplBase : public DeviceDataProviderImplBaseHack {
DISALLOW_COPY_AND_ASSIGN(DeviceDataProviderImplBase);
};
-typedef DeviceDataProviderImplBase<RadioData> RadioDataProviderImplBase;
typedef DeviceDataProviderImplBase<WifiData> WifiDataProviderImplBase;
// A device data provider
@@ -363,7 +301,6 @@ class DeviceDataProvider : public base::NonThreadSafe {
DISALLOW_COPY_AND_ASSIGN(DeviceDataProvider);
};
-typedef DeviceDataProvider<RadioData> RadioDataProvider;
typedef DeviceDataProvider<WifiData> WifiDataProvider;
#endif // CONTENT_BROWSER_GEOLOCATION_DEVICE_DATA_PROVIDER_H_
« no previous file with comments | « no previous file | content/browser/geolocation/device_data_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698