Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 10534120: Remove RadioData from geolocation (Closed)

Created:
8 years, 6 months ago by joth
Modified:
8 years, 3 months ago
Reviewers:
John Knottenbelt
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org, Steve Block
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove RadioData from geolocation This has never been used. Removing it closes some TODOs, and allows for futher cleanup, specifically as described in http://crbug.com/140789#c2 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141951

Patch Set 1 #

Patch Set 2 : fix content_unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -185 lines) Patch
M content/browser/geolocation/device_data_provider.h View 4 chunks +0 lines, -63 lines 0 comments Download
M content/browser/geolocation/device_data_provider.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M content/browser/geolocation/empty_device_data_provider.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/geolocation/network_location_provider.h View 2 chunks +2 lines, -8 lines 0 comments Download
M content/browser/geolocation/network_location_provider.cc View 10 chunks +4 lines, -22 lines 0 comments Download
M content/browser/geolocation/network_location_provider_unittest.cc View 1 4 chunks +0 lines, -35 lines 0 comments Download
M content/browser/geolocation/network_location_request.h View 3 chunks +0 lines, -3 lines 0 comments Download
M content/browser/geolocation/network_location_request.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
joth
8 years, 6 months ago (2012-06-12 19:08:24 UTC) #1
John Knottenbelt
LGTM. Thanks, Joth!
8 years, 6 months ago (2012-06-13 08:43:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/10534120/6001
8 years, 6 months ago (2012-06-13 18:24:00 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-13 20:07:56 UTC) #4
Change committed as 141951

Powered by Google App Engine
This is Rietveld 408576698