Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1333)

Issue 10534115: Add an untrusted NaCl build for IPC. (Closed)

Created:
8 years, 6 months ago by bbudge
Modified:
8 years, 6 months ago
Reviewers:
jam, bradn
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add an untrusted NaCl build for IPC. BUG=116317 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141834

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -73 lines) Patch
M build/all.gyp View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M ipc/ipc.gyp View 1 2 3 2 chunks +45 lines, -20 lines 0 comments Download
M ipc/ipc.gypi View 1 2 3 2 chunks +9 lines, -49 lines 0 comments Download
A ipc/ipc_untrusted.gyp View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
bbudge
Had to move 'ipc' target into the .gyp file to avoid duplicate targets. Also removed ...
8 years, 6 months ago (2012-06-12 17:28:22 UTC) #1
jam
I defer to bradnelson on this, I don't even know why we have a gyp ...
8 years, 6 months ago (2012-06-12 20:43:00 UTC) #2
bbudge
8 years, 6 months ago (2012-06-12 20:50:47 UTC) #3
bbudge
8 years, 6 months ago (2012-06-12 20:50:48 UTC) #4
bradn
As this target now depends on base, case you alter build/all.gyp to refer to this ...
8 years, 6 months ago (2012-06-12 20:58:23 UTC) #5
bbudge
Done. PTAL
8 years, 6 months ago (2012-06-12 22:11:09 UTC) #6
bbudge
The Windows try failures were real. I needed to move the conditional 64 bit target ...
8 years, 6 months ago (2012-06-12 22:18:28 UTC) #7
bradn
lgtm
8 years, 6 months ago (2012-06-12 22:35:55 UTC) #8
jam
lgtm
8 years, 6 months ago (2012-06-13 00:49:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/10534115/9005
8 years, 6 months ago (2012-06-13 00:55:25 UTC) #10
commit-bot: I haz the power
8 years, 6 months ago (2012-06-13 02:20:21 UTC) #11
Change committed as 141834

Powered by Google App Engine
This is Rietveld 408576698