Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: chrome/chrome_installer.gypi

Issue 10534113: Only copy keychain_reauthorize in official builds (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_installer.gypi
===================================================================
--- chrome/chrome_installer.gypi (revision 141065)
+++ chrome/chrome_installer.gypi (working copy)
@@ -926,6 +926,40 @@
},
], # actions
}], # buildtype=="Official"
+ ['branding=="Chrome" and buildtype=="Official"', {
+ 'actions': [
+ {
+ # copy_keychain_reauthorize.sh explains why this isn't in a
+ # 'copies' block, but briefly: this is a prebuilt signed
+ # binary component that relies on a correct signature to
+ # function properly, and a normal 'copies' block sadly makes
+ # a trivial modification to the file such that its signature
+ # is no longer valid.
+ 'action_name': 'Copy keychain_reauthorize',
+ 'variables': {
+ 'keychain_reauthorize_path': 'tools/build/mac/copy_keychain_reauthorize.sh',
+ 'keychain_reauthorize_normal_path': 'installer/mac/internal/keychain_reauthorize/com.google.Chrome',
+ 'keychain_reauthorize_canary_path': 'installer/mac/internal/keychain_reauthorize/com.google.Chrome.canary',
+ 'keychain_reauthorize_output_dir': '<(mac_packaging_dir)/.keychain_reauthorize',
+ },
+ 'inputs': [
+ '<(keychain_reauthorize_path)',
+ '<(keychain_reauthorize_normal_path)',
+ '<(keychain_reauthorize_canary_path)',
+ ],
+ 'outputs': [
+ '<(keychain_reauthorize_output_dir)/com.google.Chrome',
+ '<(keychain_reauthorize_output_dir)/com.google.Chrome.canary',
+ ],
+ 'action': [
+ '<(keychain_reauthorize_path)',
+ '<(keychain_reauthorize_output_dir)',
+ '<(keychain_reauthorize_normal_path)',
+ '<(keychain_reauthorize_canary_path)',
+ ],
+ },
+ ], # actions
+ }], # branding=="Chrome" and buildtype=="Official"
], # conditions
'copies': [
{
@@ -965,38 +999,6 @@
], # conditions
},
], # copies
- 'actions': [
- {
- # copy_keychain_reauthorize.sh explains why this isn't in a
- # 'copies' block, but briefly: this is a prebuilt signed binary
- # component that relies on a correct signature to function
- # properly, and a normal 'copies' block sadly makes a trivial
- # modification to the file such that its signature is no longer
- # valid.
- 'action_name': 'Copy keychain_reauthorize',
- 'variables': {
- 'keychain_reauthorize_path': 'tools/build/mac/copy_keychain_reauthorize.sh',
- 'keychain_reauthorize_normal_path': 'installer/mac/internal/keychain_reauthorize/com.google.Chrome',
- 'keychain_reauthorize_canary_path': 'installer/mac/internal/keychain_reauthorize/com.google.Chrome.canary',
- 'keychain_reauthorize_output_dir': '<(mac_packaging_dir)/.keychain_reauthorize',
- },
- 'inputs': [
- '<(keychain_reauthorize_path)',
- '<(keychain_reauthorize_normal_path)',
- '<(keychain_reauthorize_canary_path)',
- ],
- 'outputs': [
- '<(keychain_reauthorize_output_dir)/com.google.Chrome',
- '<(keychain_reauthorize_output_dir)/com.google.Chrome.canary',
- ],
- 'action': [
- '<(keychain_reauthorize_path)',
- '<(keychain_reauthorize_output_dir)',
- '<(keychain_reauthorize_normal_path)',
- '<(keychain_reauthorize_canary_path)',
- ],
- },
- ], # actions
}, # target: installer_packaging
{
'target_name': 'gcapi_lib',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698