Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 10534108: Disable platform app shortcut creation on Mac (Closed)

Created:
8 years, 6 months ago by benwells
Modified:
8 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Disable platform app shortcut creation on Mac Platform app shortcuts on the mac don't work. Until we can properly support shortcuts on the Mac we need to disable their automatic creation at install time. BUG=132161 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141802

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M chrome/browser/extensions/app_shortcut_manager.cc View 2 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
benwells
I have not tested this on a mac, if review and trybots are good i ...
8 years, 6 months ago (2012-06-12 08:00:29 UTC) #1
Mihai Parparita -not on Chrome
LGTM
8 years, 6 months ago (2012-06-12 14:15:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10534108/1
8 years, 6 months ago (2012-06-12 23:27:21 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-13 00:30:00 UTC) #4
Change committed as 141802

Powered by Google App Engine
This is Rietveld 408576698