Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10534098: TabContentsWrapper -> TabContents, part 51. (Closed)

Created:
8 years, 6 months ago by Avi (use Gerrit)
Modified:
8 years, 6 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, asanka, dbeam+watch-ntp_chromium.org, Randy Smith (Not in Mondays), feature-media-reviews_chromium.org, eroman, estade+watch_chromium.org, mmenke
Visibility:
Public.

Description

TabContentsWrapper -> TabContents, part 51. browser/ui/webui BUG=131026 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141582

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -71 lines) Patch
M chrome/browser/ui/webui/bookmarks_ui_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_webui.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/downloads_dom_handler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/feedback_ui.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/inspect_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/media/media_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_login_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/options_ui2_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/web_dialog_web_contents_delegate.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_browsertest.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_unittest.cc View 7 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
8 years, 6 months ago (2012-06-11 21:02:42 UTC) #1
Evan Stade
lgtm http://codereview.chromium.org/10534098/diff/1/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc File chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (right): http://codereview.chromium.org/10534098/diff/1/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc#newcode128 chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:128: (!web_ui || no wrap
8 years, 6 months ago (2012-06-11 23:33:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10534098/7001
8 years, 6 months ago (2012-06-12 00:05:08 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 01:11:52 UTC) #4 
Change committed as 141582

Powered by Google App Engine
This is Rietveld 408576698