TabContentsWrapper -> TabContents, part 37.

TabContentsWrapper -> TabContents, part 37.

browser/ui/cocoa

BUG=131026
TEST=no change

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141421

[Nico, 2012-06-11 16:38:07]

LGTM stamp (I looked at everything, but just quickly)

So, the history for this is:

1. We used to have TabContents and WebContents
2. Brett unified them into TabContents because all TabContents were WebContents
anyway
3. Pink split off the hosting part of TabContents into a small, focused
TabContents and the grab bag rest TabContentsWrapper, because TabContents got
too big
4. That small TabContents got renamed to WebContents
5. Now TabContentsWrapper is getting renamed to TabContents

Does that sound about right?

[Avi (use Gerrit), 2012-06-11 16:42:08]

On 2012/06/11 16:38:07, Nico wrote:
> LGTM stamp (I looked at everything, but just quickly)
> 
> So, the history for this is:
> 
> 1. We used to have TabContents and WebContents
> 2. Brett unified them into TabContents because all TabContents were
WebContents
> anyway
> 3. Pink split off the hosting part of TabContents into a small, focused
> TabContents and the grab bag rest TabContentsWrapper, because TabContents got
> too big
> 4. That small TabContents got renamed to WebContents
> 5. Now TabContentsWrapper is getting renamed to TabContents
> 
> Does that sound about right?

3. Pink made a small TabContentsWrapper wrapping TabContents
3.5 Avi spent a year moving things out of TabContents to TabContentsWrapper

but yes, you've got the history right.

[commit-bot: I haz the power, 2012-06-11 16:42:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10534093/1

[commit-bot: I haz the power, 2012-06-11 16:42:48]

Presubmit check for 10534093-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  chrome/browser/ui/cocoa/ssl_client_certificate_selector.mm, line 31, 84 chars

Presubmit checks took 4.0s to calculate.

[Nico, 2012-06-11 16:43:31]

On 2012/06/11 16:42:08, Avi wrote:
> On 2012/06/11 16:38:07, Nico wrote:
> > LGTM stamp (I looked at everything, but just quickly)
> > 
> > So, the history for this is:
> > 
> > 1. We used to have TabContents and WebContents
> > 2. Brett unified them into TabContents because all TabContents were
> WebContents
> > anyway
> > 3. Pink split off the hosting part of TabContents into a small, focused
> > TabContents and the grab bag rest TabContentsWrapper, because TabContents
got
> > too big
> > 4. That small TabContents got renamed to WebContents
> > 5. Now TabContentsWrapper is getting renamed to TabContents
> > 
> > Does that sound about right?
> 
> 3. Pink made a small TabContentsWrapper wrapping TabContents
> 3.5 Avi spent a year moving things out of TabContents to TabContentsWrapper
> 
> but yes, you've got the history right.

Sorry, didn't mean to blame pink for everything ;-)