Issue 10534091: Implemented StoreIC for setters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10534091: Implemented StoreIC for setters. (Closed)

Created:
8 years, 6 months ago by Sven Panne

Modified:
8 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google), Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implemented StoreIC for setters. Committed: https://code.google.com/p/v8/source/detail?r=11771

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+231 lines, -9 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	1 chunk	+45 lines, -0 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1 chunk	+46 lines, -0 lines	2 comments	Download
M	src/ic.cc	View	2 chunks	+21 lines, -9 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	1 chunk	+46 lines, -0 lines	0 comments	Download
M	src/stub-cache.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	src/stub-cache.cc	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 chunk	+46 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

8 years, 6 months ago (2012-06-17 10:17:09 UTC) #3

DBC

[side note: this is awesome!]

http://codereview.chromium.org/10534091/diff/1/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (right):

http://codereview.chromium.org/10534091/diff/1/src/ia32/stub-cache-ia32.cc#ne...
src/ia32/stub-cache-ia32.cc:2603: __ CheckMap(edx, Handle<Map>(receiver->map()),
&miss, DO_SMI_CHECK,
Is there any reason why we are not giving benefits to setters defined on
prototypes?

http://codereview.chromium.org/10534091/diff/1/src/ia32/stub-cache-ia32.cc#ne...
src/ia32/stub-cache-ia32.cc:2612: // Call the JavaScript getter with the
receiver and the value on the stack.
s/getter/setter/

Expand Messages | Collapse Messages