Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: src/d8.cc

Issue 10534090: Rollback of r11719, r11717, r11716, r11714, r11700, r11699, r11697, r11695, r11694 in trunk branch. (Closed) Base URL: https://v8.googlecode.com/svn/trunk
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/flag-definitions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index 7a01d55148fa768c0eaba8a5a472f3513ef46d6b..297bf79d09d5101bfd255d1b10483999e3644114 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -443,9 +443,8 @@ Handle<Value> Shell::CreateExternalArray(const Arguments& args,
void Shell::ExternalArrayWeakCallback(Persistent<Value> object, void* data) {
HandleScope scope;
- int32_t length =
- object->ToObject()->Get(String::New("byteLength"))->Uint32Value();
- V8::AdjustAmountOfExternalAllocatedMemory(-length);
+ Local<Value> length = object->ToObject()->Get(String::New("byteLength"));
+ V8::AdjustAmountOfExternalAllocatedMemory(-length->Uint32Value());
delete[] static_cast<uint8_t*>(data);
object.Dispose();
}
@@ -1020,7 +1019,7 @@ static char* ReadChars(const char* name, int* size_out) {
Handle<Value> Shell::ReadBuffer(const Arguments& args) {
- ASSERT(sizeof(char) == sizeof(uint8_t)); // NOLINT
+ STATIC_ASSERT(sizeof(char) == sizeof(uint8_t)); // NOLINT
String::Utf8Value filename(args[0]);
int length;
if (*filename == NULL) {
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698