Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 10534090: Rollback of r11719, r11717, r11716, r11714, r11700, r11699, r11697, r11695, r11694 in trunk branch. (Closed)

Created:
8 years, 6 months ago by rossberg
Modified:
8 years, 6 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Rollback of r11719, r11717, r11716, r11714, r11700, r11699, r11697, r11695, r11694 in trunk branch. (Rolls back prototype chain checking to verify regression cause.) Remove one more case behind --es5_readonly flag. MIPS: Implement correct checking for inherited readonliness on assignment. Temporarily hack test frameworks to use the temporary flag. :( Put inherited readonliness behind a flag, since it currently breaks WebKit bindings massively. STATIC_ASSERT is not available in shared build. Silence Windows warning. Adapt test expectations (fewer tests failing). Fix merge issue. Implement correct checking for inherited readonliness on assignment. R=danno@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11759

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -727 lines) Patch
M src/arm/stub-cache-arm.cc View 6 chunks +12 lines, -62 lines 0 comments Download
M src/d8.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 6 chunks +8 lines, -38 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 7 chunks +14 lines, -62 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 7 chunks +13 lines, -64 lines 0 comments Download
M src/objects.h View 3 chunks +13 lines, -13 lines 0 comments Download
M src/objects.cc View 9 chunks +132 lines, -135 lines 0 comments Download
M src/stub-cache.h View 2 chunks +8 lines, -11 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 7 chunks +13 lines, -62 lines 0 comments Download
M test/cctest/test-api.cc View 5 chunks +9 lines, -12 lines 0 comments Download
M test/mjsunit/harmony/proxies.js View 4 chunks +10 lines, -20 lines 0 comments Download
M test/mjsunit/override-read-only-property.js View 2 chunks +4 lines, -6 lines 0 comments Download
D test/mjsunit/readonly.js View 1 chunk +0 lines, -228 lines 0 comments Download
M test/mjsunit/regress/regress-1199637.js View 2 chunks +3 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-334.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/with-readonly.js View 2 chunks +2 lines, -4 lines 0 comments Download
M test/mozilla/mozilla.status View 2 chunks +4 lines, -0 lines 0 comments Download
M test/mozilla/testcfg.py View 1 chunk +0 lines, -1 line 0 comments Download
M test/test262/test262.status View 1 chunk +11 lines, -0 lines 0 comments Download
M test/test262/testcfg.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
rossberg
8 years, 6 months ago (2012-06-11 12:01:11 UTC) #1
danno
8 years, 6 months ago (2012-06-11 12:10:27 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698