Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

Issue 10534084: Issue 3426. Don't warn if superclass does not specify default parameter value (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
diff --git a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
index 4ec32da371a46757528fd9d4f5241e23b9b852a0..76a3394ed91e1bee4b3cf4ecbd8a21bbae40bb5a 100644
--- a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
+++ b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
@@ -2535,11 +2535,14 @@ public class TypeAnalyzer implements DartCompilationPhase {
if (namedIterator.hasNext()) {
VariableElement parameter = namedIterator.next();
if (Objects.equal(parameter.getName(), superParameter.getName())) {
- if (!Objects.equal(ObjectUtils.toString(parameter.getDefaultValue()),
- ObjectUtils.toString(superParameter.getDefaultValue()))) {
+ DartExpression superDefValue = superParameter.getDefaultValue();
+ DartExpression defValue = parameter.getDefaultValue();
+ if (superDefValue != null
+ && !Objects.equal(ObjectUtils.toString(defValue),
+ ObjectUtils.toString(superDefValue))) {
onError(parameter.getSourceInfo(),
TypeErrorCode.CANNOT_OVERRIDE_METHOD_DEFAULT_VALUE, method.getName(),
- superParameter.getDefaultValue());
+ superDefValue);
}
continue;
}
« no previous file with comments | « no previous file | compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698