Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 10534082: Issue 3449. Enable default values for parameters in abstract and interface methods (Closed)

Created:
8 years, 6 months ago by scheglov
Modified:
8 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 3449. Enable default values for parameters in abstract and interface methods http://code.google.com/p/dart/issues/detail?id=3449 R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8494

Patch Set 1 #

Patch Set 2 : http://code.google.com/p/dart/issues/detail?id=3426 #

Patch Set 3 : Rollback changes from other CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -77 lines) Patch
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 1 chunk +0 lines, -14 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java View 1 chunk +0 lines, -4 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java View 1 chunk +0 lines, -12 lines 0 comments Download
M tests/co19/co19-compiler.status View 2 chunks +0 lines, -10 lines 0 comments Download
D tests/language/named_parameters5_negative_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/language/named_parameters7_negative_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 6 months ago (2012-06-11 02:02:27 UTC) #1
Brian Wilkerson
8 years, 6 months ago (2012-06-11 15:14:58 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698