Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 10534075: [sync] Make SetSetupInProgress kick sync engine when needed (Closed)

Created:
8 years, 6 months ago by nyquist
Modified:
8 years, 6 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

[sync] Make SetSetupInProgress kick sync engine when needed When we clear the sync setup_in_progress flag, and the sync engine is not already initialized, we should should set the sync setup completed flag, and kick the sync engine. BUG=None TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141952

Patch Set 1 #

Patch Set 2 : First try at fixing unit_tests #

Total comments: 1

Patch Set 3 : Remove call to SetSyncSetupCompleted, and change kick-mechanism #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -20 lines) Patch
M chrome/browser/sync/profile_sync_service.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_harness.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 1 4 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nyquist
Ready for review.
8 years, 6 months ago (2012-06-08 22:18:43 UTC) #1
Andrew T Wilson (Slow)
http://codereview.chromium.org/10534075/diff/6001/chrome/browser/sync/profile_sync_service.cc File chrome/browser/sync/profile_sync_service.cc (right): http://codereview.chromium.org/10534075/diff/6001/chrome/browser/sync/profile_sync_service.cc#newcode1008 chrome/browser/sync/profile_sync_service.cc:1008: SetSyncSetupCompleted(); I'm somewhat leery about calling SetSyncSetupCompleted() here - ...
8 years, 6 months ago (2012-06-11 18:17:59 UTC) #2
nyquist
Removed call to SetSyncSetupCompleted(), and changed sync engine kick-mechanism. PTAL.
8 years, 6 months ago (2012-06-11 23:33:11 UTC) #3
Andrew T Wilson (Slow)
LGTM
8 years, 6 months ago (2012-06-11 23:42:19 UTC) #4
nyquist
estade@ for chrome/browser/ui/webui/
8 years, 6 months ago (2012-06-13 00:38:42 UTC) #5
Evan Stade
lgtm. feel free to TBR owners reviews for changes of the nature found in sync_setup_handler.cc
8 years, 6 months ago (2012-06-13 02:34:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/10534075/3002
8 years, 6 months ago (2012-06-13 18:32:05 UTC) #7
commit-bot: I haz the power
8 years, 6 months ago (2012-06-13 20:10:20 UTC) #8
Change committed as 141952

Powered by Google App Engine
This is Rietveld 408576698