In analyzer, catch use of continue and break in inappropriate places

tests/language/label_test.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file

[Brian Wilkerson, 2012/06/08 18:49:05]

nit: copyright year

 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // Dart test program to test check that we can parse labels.
 
 
 class Helper {
 
   static int ticks;
 
   // Helper function to prevent endless loops in case labels or
@@ skipping 202 matching lines @@
       } finally {
       }
       break;
     }
     Expect.equals(111, i);
 
     return i;
   }
 
    static test11() {
-     // Kind of odd, but is valid and shouldn't be flagged as useless either.
-     L: break L;
+     while (true) {

[Brian Wilkerson, 2012/06/08 18:49:05]

Looking at the spec, I don't see where the original version of this code is
disallowed. (That is, I don't see why we need the while loop wrapped around it.)

[zundel, 2012/06/08 20:15:08]

You are right. I had coded it incorrectly at first then when I found more
instances of this I went back and carefully re-read the spec and found out I was
wrong.

Reverted.

+       // Kind of odd, but is valid and shouldn't be flagged as useless either.
+       L: break L; 
+     }
      return 111;
    }
 
    static test12() {
      int i = 111;
 
      // label the inner block on compound stmts
      if (true) L: {
        while (doAgain()) {
          break L;
@@ skipping 71 matching lines @@
     Expect.equals(111, Helper.test9());
     Expect.equals(111, Helper.test10());
     Expect.equals(111, Helper.test11());
     Expect.equals(111, Helper.test12());
   }
 }
 
 main() {
   LabelTest.testMain();
 }