Use ICU to get the script of the browser's locale.

Use ICU to get the script of the browser's locale.

This eliminates the need for a hardcoded locale list for each font preference
when deciding whether the script for the browser's locale is equal to the
script of the font pref.

BUG=128298
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141612

[falken, 2012-06-08 12:45:34]

Jungshik, can you please review?

[jungshik at Google, 2012-06-11 19:56:29]

LGTM

http://codereview.chromium.org/10534057/diff/1/chrome/browser/ui/prefs/prefs_...
File chrome/browser/ui/prefs/prefs_tab_helper.cc (right):

http://codereview.chromium.org/10534057/diff/1/chrome/browser/ui/prefs/prefs_...
chrome/browser/ui/prefs/prefs_tab_helper.cc:442: // primary script of the
browser's locale.  For example, if the pref is for
I think "If the script it is for .... locale" can be simplified to 
"if it is for the primary script of the browser's UI locale."

[falken, 2012-06-12 01:47:57]

Peter: Can you please review?
Jungshik: Thanks!

http://codereview.chromium.org/10534057/diff/1/chrome/browser/ui/prefs/prefs_...
File chrome/browser/ui/prefs/prefs_tab_helper.cc (right):

http://codereview.chromium.org/10534057/diff/1/chrome/browser/ui/prefs/prefs_...
chrome/browser/ui/prefs/prefs_tab_helper.cc:442: // primary script of the
browser's locale.  For example, if the pref is for
On 2012/06/11 19:56:29, Jungshik Shin wrote:
> I think "If the script it is for .... locale" can be simplified to 
> "if it is for the primary script of the browser's UI locale."  

Done.

[Peter Kasting, 2012-06-12 01:54:22]

LGTM

http://codereview.chromium.org/10534057/diff/4002/chrome/browser/ui/prefs/pre...
File chrome/browser/ui/prefs/prefs_tab_helper.cc (right):

http://codereview.chromium.org/10534057/diff/4002/chrome/browser/ui/prefs/pre...
chrome/browser/ui/prefs/prefs_tab_helper.cc:217: DCHECK(len >
kScriptNameLength);
Nit: DCHECK_GT

http://codereview.chromium.org/10534057/diff/4002/chrome/browser/ui/prefs/pre...
chrome/browser/ui/prefs/prefs_tab_helper.cc:221: return (UScriptCode) code;
Nit: Use C++-style casts

[falken, 2012-06-12 02:10:58]

Thanks for the review.

http://codereview.chromium.org/10534057/diff/4002/chrome/browser/ui/prefs/pre...
File chrome/browser/ui/prefs/prefs_tab_helper.cc (right):

http://codereview.chromium.org/10534057/diff/4002/chrome/browser/ui/prefs/pre...
chrome/browser/ui/prefs/prefs_tab_helper.cc:217: DCHECK(len >
kScriptNameLength);
On 2012/06/12 01:54:22, Peter Kasting wrote:
> Nit: DCHECK_GT

Done.

http://codereview.chromium.org/10534057/diff/4002/chrome/browser/ui/prefs/pre...
chrome/browser/ui/prefs/prefs_tab_helper.cc:221: return (UScriptCode) code;
On 2012/06/12 01:54:22, Peter Kasting wrote:
> Nit: Use C++-style casts

Done.

[commit-bot: I haz the power, 2012-06-12 02:18:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/falken@chromium.org/10534057/7001

[commit-bot: I haz the power, 2012-06-12 04:00:18]

Change committed as 141612