[refactor] Rename some constants in net-internals. Mostly just removes a redundant "Log" prefix.

chrome/browser/resources/net_internals/main.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Dictionary of constants (Initialized soon after loading by data from browser,
  * updated on load log).  The *Types dictionaries map strings to numeric IDs,
  * while the *TypeNames are the other way around.
  */
-var LogEventType = null;
-var LogEventTypeNames = null;
-var LogEventPhase = null;
-var LogSourceType = null;
-var LogSourceTypeNames = null;
+var EventType = null;
+var EventTypeNames = null;
+var EventPhase = null;
+var EventSourceType = null;
+var EventSourceTypeNames = null;
 var LogLevelType = null;
 var ClientInfo = null;
 var NetError = null;
 var LoadFlag = null;
 var AddressFamily = null;
 
 /**
  * Dictionary of all constants, used for saving log files.
  */
 var Constants = null;
@@ skipping 212 matching lines @@
  * Loads all constants from |constants|.  On failure, global dictionaries are
  * not modifed.
  * @param {Object} receivedConstants The map of received constants.
  */
 ConstantsObserver.prototype.onReceivedConstants = function(receivedConstants) {
   if (!areValidConstants(receivedConstants))
     return;
 
   Constants = receivedConstants;
 
-  LogEventType = Constants.logEventTypes;
-  LogEventTypeNames = makeInverseMap(LogEventType);
-  LogEventPhase = Constants.logEventPhase;
-  LogSourceType = Constants.logSourceType;
-  LogSourceTypeNames = makeInverseMap(LogSourceType);
+  EventType = Constants.eventType;
+  EventTypeNames = makeInverseMap(EventType);
+  EventPhase = Constants.eventPhase;
+  EventSourceType = Constants.sourceType;

[mmenke, 2012/06/08 00:12:51]

This breaks log loading compatibility.

[eroman, 2012/06/08 00:13:29]

Good point. Let me rework that!

+  EventSourceTypeNames = makeInverseMap(EventSourceType);
   LogLevelType = Constants.logLevelType;
   ClientInfo = Constants.clientInfo;
   LoadFlag = Constants.loadFlag;
   NetError = Constants.netError;
   AddressFamily = Constants.addressFamily;
 
   timeutil.setTimeTickOffset(Constants.timeTickOffset);
 };
 
 /**
  * Returns true if it's given a valid-looking constants object.
  * @param {Object} receivedConstants The received map of constants.
  * @return {boolean} True if the |receivedConstants| object appears valid.
  */
 function areValidConstants(receivedConstants) {
   return typeof(receivedConstants) == 'object' &&
-         typeof(receivedConstants.logEventTypes) == 'object' &&
+         typeof(receivedConstants.eventType) == 'object' &&
          typeof(receivedConstants.clientInfo) == 'object' &&
-         typeof(receivedConstants.logEventPhase) == 'object' &&
-         typeof(receivedConstants.logSourceType) == 'object' &&
+         typeof(receivedConstants.eventPhase) == 'object' &&
+         typeof(receivedConstants.sourceType) == 'object' &&

[mmenke, 2012/06/08 00:12:51]

Ditto.

          typeof(receivedConstants.logLevelType) == 'object' &&
          typeof(receivedConstants.loadFlag) == 'object' &&
          typeof(receivedConstants.netError) == 'object' &&
          typeof(receivedConstants.addressFamily) == 'object' &&
          typeof(receivedConstants.timeTickOffset) == 'string' &&
          typeof(receivedConstants.logFormatVersion) == 'number';
 }
 
 /**
  * Returns the name for netError.
@@ skipping 14 matching lines @@
  * Returns a string representation of |family|.
  * @param {number} family An AddressFamily
  * @return {string} A representation of the given family.
  */
 function addressFamilyToString(family) {
   var str = getKeyWithValue(AddressFamily, family);
   // All the address family start with ADDRESS_FAMILY_*.
   // Strip that prefix since it is redundant and only clutters the output.
   return str.replace(/^ADDRESS_FAMILY_/, '');
 }