Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10534053: ash/chromeos: "Search" key to toggle app list. (Closed)

Created:
8 years, 6 months ago by xiyuan
Modified:
8 years, 6 months ago
Reviewers:
mazda, sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org, mazda+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

ash/chromeos: "Search" key to toggle app list. - "Search" key to toggle app list; - Remove old "Ctrl+Search" shortcut for app list; - Remove ShellDelegate::Search since it no longer in use; BUG=131703 TEST=Verify "Search" key toggles app list and old "Ctrl+Search" stops working. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141290

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase, SEARCH_KEY -> TOGGLE_APP_LIST #

Total comments: 2

Patch Set 3 : for nit in #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -56 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ash/accelerators/accelerator_table.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/accelerators/accelerator_table.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/shell_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ash/chrome_shell_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ash/chrome_shell_delegate.cc View 1 2 2 chunks +0 lines, -32 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
xiyuan
8 years, 6 months ago (2012-06-07 23:14:13 UTC) #1
sky
LGTM
8 years, 6 months ago (2012-06-08 02:59:39 UTC) #2
mazda
http://codereview.chromium.org/10534053/diff/1/ash/accelerators/accelerator_controller.cc File ash/accelerators/accelerator_controller.cc (left): http://codereview.chromium.org/10534053/diff/1/ash/accelerators/accelerator_controller.cc#oldcode337 ash/accelerators/accelerator_controller.cc:337: case SEARCH_KEY: How about removing SEARCH_KEY instead of TOGGLE_APP_LIST? ...
8 years, 6 months ago (2012-06-08 03:43:57 UTC) #3
xiyuan
http://codereview.chromium.org/10534053/diff/1/ash/accelerators/accelerator_controller.cc File ash/accelerators/accelerator_controller.cc (left): http://codereview.chromium.org/10534053/diff/1/ash/accelerators/accelerator_controller.cc#oldcode337 ash/accelerators/accelerator_controller.cc:337: case SEARCH_KEY: On 2012/06/08 03:43:57, mazda wrote: > How ...
8 years, 6 months ago (2012-06-08 16:37:12 UTC) #4
mazda
LGTM with a nit http://codereview.chromium.org/10534053/diff/1014/chrome/browser/ui/views/ash/chrome_shell_delegate.cc File chrome/browser/ui/views/ash/chrome_shell_delegate.cc (right): http://codereview.chromium.org/10534053/diff/1014/chrome/browser/ui/views/ash/chrome_shell_delegate.cc#newcode20 chrome/browser/ui/views/ash/chrome_shell_delegate.cc:20: #include "chrome/browser/ui/browser_list.h" This can be ...
8 years, 6 months ago (2012-06-08 16:57:57 UTC) #5
xiyuan
http://codereview.chromium.org/10534053/diff/1014/chrome/browser/ui/views/ash/chrome_shell_delegate.cc File chrome/browser/ui/views/ash/chrome_shell_delegate.cc (right): http://codereview.chromium.org/10534053/diff/1014/chrome/browser/ui/views/ash/chrome_shell_delegate.cc#newcode20 chrome/browser/ui/views/ash/chrome_shell_delegate.cc:20: #include "chrome/browser/ui/browser_list.h" On 2012/06/08 16:57:57, mazda wrote: > This ...
8 years, 6 months ago (2012-06-08 17:09:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10534053/6003
8 years, 6 months ago (2012-06-08 20:27:34 UTC) #7
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 21:31:22 UTC) #8 
Change committed as 141290

Powered by Google App Engine
This is Rietveld 408576698