Issue 10534037: Add text input types newly introduced in WebKit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10534037: Add text input types newly introduced in WebKit (Closed)

Created:
8 years, 6 months ago by yosin_UTC9

Modified:
8 years, 6 months ago

Reviewers:
jamesr, Yusuke Sato, piman

CC:
chromium-reviews, yusukes+watch_chromium.org, jochen+watch-content_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add text input types newly introduced in WebKit BUG=128954 TEST=No need. This patch doesn't change behavior. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141167

Patch Set 1 #

Patch Set 2 : Remove TEXT_INPUT_TYPE_MAX_PLUS_1 for switch/case with clang friendly #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	content/renderer/render_widget.cc	View	1	1 chunk	+13 lines, -1 line	0 comments	Download
	M	ui/base/ime/text_input_type.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yosin_UTC9

Hi guys, Could you review this patch? We, WebKit forms team, have been having hard ...

8 years, 6 months ago (2012-06-07 09:08:38 UTC) #1

Yusuke Sato

ui/base/ime/ LGTM On 2012/06/07 09:08:38, Yoshifumi Inoue wrote: > Hi guys, > > Could you ...

8 years, 6 months ago (2012-06-07 09:14:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/10534037/3002

8 years, 6 months ago (2012-06-08 00:59:47 UTC) #4

Change committed as 141167

Expand Messages | Collapse Messages