Issue 10534027: Sign Chrome with the new Apple Developer ID certificate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10534027: Sign Chrome with the new Apple Developer ID certificate (Closed)

Created:
8 years, 6 months ago by Mark Mentovai

Modified:
8 years, 6 months ago

Reviewers:
TVL

CC:
chromium-reviews, grt+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Sign Chrome with the new Apple Developer ID certificate. This removes the at-launch reauthorization step, but retains the at-update reauthorization step for user Keystone tickets. The at-update helper stubs are now prebuilt binaries signed with the old certificate, so the old target for the stubs is removed and replaced with a straight file copy. The new designated requirement only allows access to Keychain items for Chrome official builds (canary and non-Canary) signed by the new Developer ID certificate. BUG=116210 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140817

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -101 lines)			Patch
M	chrome/browser/chrome_browser_main_mac.mm	View		2 chunks	+1 line, -10 lines	0 comments	Download
M	chrome/chrome_installer.gypi	View		2 chunks	+7 lines, -8 lines	0 comments	Download
D	chrome/installer/mac/keychain_reauthorize_main.cc	View	1	1 chunk	+0 lines, -81 lines	0 comments	Download
M	chrome/installer/mac/sign_app.sh.in	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

TVL

lgtm https://chromiumcodereview.appspot.com/10534027/diff/1/chrome/chrome_installer.gypi File chrome/chrome_installer.gypi (left): https://chromiumcodereview.appspot.com/10534027/diff/1/chrome/chrome_installer.gypi#oldcode975 chrome/chrome_installer.gypi:975: 'installer/mac/keychain_reauthorize_main.cc', do you want to kill off this ...

8 years, 6 months ago (2012-06-06 19:08:08 UTC) #2

Mark Mentovai

8 years, 6 months ago (2012-06-06 19:10:28 UTC) #3

https://chromiumcodereview.appspot.com/10534027/diff/1/chrome/chrome_installe...
File chrome/chrome_installer.gypi (left):

https://chromiumcodereview.appspot.com/10534027/diff/1/chrome/chrome_installe...
chrome/chrome_installer.gypi:975: 'installer/mac/keychain_reauthorize_main.cc',
TVL wrote:
> do you want to kill off this source also?

I thought about keeping it as a reference since we still have the binary, but I
guess revision history is just as good for that.

Expand Messages | Collapse Messages