Revert 119486 - Merge 117978 - IndexedDB: Fire error when there are problems opening a DB

Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 75 matching lines @@
         : m_version(version)
         , m_callbacks(callbacks)
         , m_databaseCallbacks(databaseCallbacks)
     {
     }
     String m_version;
     RefPtr<IDBCallbacks> m_callbacks;
     RefPtr<IDBDatabaseCallbacks> m_databaseCallbacks;
 };
 
-PassRefPtr<IDBDatabaseBackendImpl> IDBDatabaseBackendImpl::create(const String& name, IDBBackingStore* database, IDBTransactionCoordinator* coordinator, IDBFactoryBackendImpl* factory, const String& uniqueIdentifier)
-{
-    RefPtr<IDBDatabaseBackendImpl> backend = adoptRef(new IDBDatabaseBackendImpl(name, database, coordinator, factory, uniqueIdentifier));
-    if (!backend->openInternal())
-        return 0;
-    return backend.release();
-}
-
 IDBDatabaseBackendImpl::IDBDatabaseBackendImpl(const String& name, IDBBackingStore* backingStore, IDBTransactionCoordinator* coordinator, IDBFactoryBackendImpl* factory, const String& uniqueIdentifier)
     : m_backingStore(backingStore)
     , m_id(InvalidId)
     , m_name(name)
     , m_version("")
     , m_identifier(uniqueIdentifier)
     , m_factory(factory)
     , m_transactionCoordinator(coordinator)
 {
     ASSERT(!m_name.isNull());
+    openInternal();
 }
 
-bool IDBDatabaseBackendImpl::openInternal()
+void IDBDatabaseBackendImpl::openInternal()
 {
     bool success = m_backingStore->getIDBDatabaseMetaData(m_name, m_version, m_id);
     ASSERT(success == (m_id != InvalidId));
     if (success) {
         loadObjectStores();
-        return true;
+        return;
     }
-    return m_backingStore->createIDBDatabaseMetaData(m_name, m_version, m_id);
+    if (!m_backingStore->createIDBDatabaseMetaData(m_name, m_version, m_id))
+        ASSERT_NOT_REACHED(); // FIXME: Need better error handling.
 }
 
 IDBDatabaseBackendImpl::~IDBDatabaseBackendImpl()
 {
     m_factory->removeIDBDatabaseBackend(m_identifier);
 }
 
 PassRefPtr<IDBBackingStore> IDBDatabaseBackendImpl::backingStore() const
 {
     return m_backingStore;
@@ skipping 189 matching lines @@
 void IDBDatabaseBackendImpl::open(PassRefPtr<IDBDatabaseCallbacks> callbacks)
 {
     m_databaseCallbacksSet.add(RefPtr<IDBDatabaseCallbacks>(callbacks));
 }
 
 void IDBDatabaseBackendImpl::openConnection(PassRefPtr<IDBCallbacks> callbacks)
 {
     if (!m_pendingDeleteCalls.isEmpty() || m_runningVersionChangeTransaction || !m_pendingSetVersionCalls.isEmpty())
         m_pendingOpenCalls.append(PendingOpenCall::create(callbacks));
     else {
-        if (m_id == InvalidId && !openInternal())
-            callbacks->onError(IDBDatabaseError::create(IDBDatabaseException::UNKNOWN_ERR, "Internal error."));
-        else
-            callbacks->onSuccess(this);
+        if (m_id == InvalidId)
+            openInternal();
+        callbacks->onSuccess(this);
     }
 }
 
 void IDBDatabaseBackendImpl::deleteDatabase(PassRefPtr<IDBCallbacks> prpCallbacks)
 {
     if (m_runningVersionChangeTransaction || !m_pendingSetVersionCalls.isEmpty()) {
         m_pendingDeleteCalls.append(PendingDeleteCall::create(prpCallbacks));
         return;
     }
     RefPtr<IDBCallbacks> callbacks = prpCallbacks;
@@ skipping 62 matching lines @@
 
 void IDBDatabaseBackendImpl::resetVersion(ScriptExecutionContext*, PassRefPtr<IDBDatabaseBackendImpl> database, const String& version)
 {
     database->m_version = version;
 }
 
 
 } // namespace WebCore
 
 #endif // ENABLE(INDEXED_DATABASE)