Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 10534013: Revert 119486 - Merge 117978 - IndexedDB: Fire error when there are problems opening a DB (Closed)

Created:
8 years, 6 months ago by kerz_chromium
Modified:
8 years, 6 months ago
Reviewers:
dgrogan
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Revert 119486 - Merge 117978 - IndexedDB: Fire error when there are problems opening a DB https://bugs.webkit.org/show_bug.cgi?id=85579 Source/WebCore: We used to either fire success or get into an infinite loop. Reviewed by Tony Chang. New unit test in Source/WebKit/chromium/tests/IDBAbortOnCorruptTest.cpp * Modules/indexeddb/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::openInternal): (WebCore::IDBDatabaseBackendImpl::openConnection): * Modules/indexeddb/IDBDatabaseBackendImpl.h: (WebCore::IDBDatabaseBackendImpl::create): (IDBDatabaseBackendImpl): * Modules/indexeddb/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::deleteDatabase): (WebCore::IDBFactoryBackendImpl::openInternal): * Modules/indexeddb/IDBFactoryBackendImpl.h: (IDBFactoryBackendImpl): * Modules/indexeddb/IDBLevelDBBackingStore.h: (IDBLevelDBBackingStore): Source/WebKit/chromium: Reviewed by Tony Chang. * WebKit.gypi: * tests/IDBAbortOnCorruptTest.cpp: Added. (WebCore): (MockIDBCallbacks): (WebCore::MockIDBCallbacks::MockIDBCallbacks): (WebCore::MockIDBCallbacks::~MockIDBCallbacks): (WebCore::MockIDBCallbacks::onError): (WebCore::MockIDBCallbacks::onSuccess): (WebCore::MockIDBCallbacks::onSuccessWithContinuation): (WebCore::MockIDBCallbacks::onSuccessWithPrefetch): (WebCore::MockIDBCallbacks::onBlocked): (FailingBackingStore): (WebCore::FailingBackingStore::~FailingBackingStore): (WebCore::FailingBackingStore::open): (WebCore::FailingBackingStore::createIDBDatabaseMetaData): (FailingIDBFactoryBackendImpl): (WebCore::FailingIDBFactoryBackendImpl::~FailingIDBFactoryBackendImpl): (WebCore::FailingIDBFactoryBackendImpl::create): (WebCore::FailingIDBFactoryBackendImpl::removeIDBDatabaseBackend): (WebCore::FailingIDBFactoryBackendImpl::openBackingStore): (WebCore::TEST): * tests/IDBFakeBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h. (WebCore): (IDBFakeBackingStore): TBR=dgrogan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10536007 TBR=dgrogan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -218 lines) Patch
M Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h View 2 chunks +5 lines, -2 lines 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp View 3 chunks +8 lines, -15 lines 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBFactoryBackendImpl.h View 2 chunks +4 lines, -6 lines 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBFactoryBackendImpl.cpp View 2 chunks +4 lines, -10 lines 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/WebKit/chromium/WebKit.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D Source/WebKit/chromium/tests/IDBAbortOnCorruptTest.cpp View 1 chunk +0 lines, -107 lines 0 comments Download
D Source/WebKit/chromium/tests/IDBFakeBackingStore.h View 1 chunk +0 lines, -74 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kerz_chromium
8 years, 6 months ago (2012-06-05 21:31:35 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698