Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 10534008: Serialize edge counts instead of indexes in heap snapshot. (Closed)

Created:
8 years, 6 months ago by alexeif
Modified:
8 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Serialize edge counts instead of indexes in heap snapshot. The serialized node structure currently holds an index of its first containment edge in the edges array. The index can be quite big (up to 7 digits for large snapshots). The patch changes the serialization format to pass node containment edge count instead. For most nodes the count is just a single digit number. This reduces serialized snapshot size and therefore its transfer time. Committed: https://code.google.com/p/v8/source/detail?r=11728

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -36 lines) Patch
M src/profile-generator.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/profile-generator.cc View 1 6 chunks +20 lines, -27 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 4 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alf
8 years, 6 months ago (2012-06-05 16:19:37 UTC) #1
loislo
https://chromiumcodereview.appspot.com/10534008/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): https://chromiumcodereview.appspot.com/10534008/diff/1/src/profile-generator.cc#newcode3329 src/profile-generator.cc:3329: SerializeEdge(edges[i], i == 0); please add an assert with ...
8 years, 6 months ago (2012-06-05 17:05:15 UTC) #2
alf
https://chromiumcodereview.appspot.com/10534008/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): https://chromiumcodereview.appspot.com/10534008/diff/1/src/profile-generator.cc#newcode3329 src/profile-generator.cc:3329: SerializeEdge(edges[i], i == 0); On 2012/06/05 17:05:15, loislo wrote: ...
8 years, 6 months ago (2012-06-05 17:20:27 UTC) #3
loislo
8 years, 6 months ago (2012-06-05 18:28:45 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698