Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 10533148: Increase old space in cctest/test-api/HugeConsStringOutOfMemory test. (Closed)

Created:
8 years, 6 months ago by palfia
Modified:
8 years, 6 months ago
Reviewers:
Erik Corry, danno
CC:
v8-dev
Visibility:
Public.

Description

Increase old space in cctest/test-api/HugeConsStringOutOfMemory test. This test is failing on MIPS since r11715 (a7d6f92c), it seems that after the modifications in bootstrapper.cc, this test runs out of old generation space on MIPS. TEST=cctest/test-api/HugeConsStringOutOfMemory BUG= Committed: https://code.google.com/p/v8/source/detail?r=11814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
Erik, I think this is fine, but can you give it a quick look?
8 years, 6 months ago (2012-06-14 13:31:12 UTC) #1
Erik Corry
lgtm
8 years, 6 months ago (2012-06-14 13:48:59 UTC) #2
danno
8 years, 6 months ago (2012-06-14 13:52:00 UTC) #3
OK, then I'll land this.

Powered by Google App Engine
This is Rietveld 408576698