Collect user metrics for clearing protected storage

Collect user metrics for clearing protected storage


BUG=116372
TEST=no


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142125

[Mike West, 2012-06-14 08:32:39]

LGTM with 2 nits.

https://chromiumcodereview.appspot.com/10533147/diff/2001/chrome/browser/brow...
File chrome/browser/browsing_data_helper.h (right):

https://chromiumcodereview.appspot.com/10533147/diff/2001/chrome/browser/brow...
chrome/browser/browsing_data_helper.h:28: ALL = UNPROTECTED_WEB | PROTECTED_WEB
| EXTENSION,
Nit: Can you add a comment here, something like "totally always add new items to
the enum above ALL". I can imagine adding "apps" as a separate origin set at
some point in the future, for instance.

https://chromiumcodereview.appspot.com/10533147/diff/2001/chrome/browser/brow...
File chrome/browser/browsing_data_remover.cc (right):

https://chromiumcodereview.appspot.com/10533147/diff/2001/chrome/browser/brow...
chrome/browser/browsing_data_remover.cc:210: forgotten_to_add_origin_mask_type);
Nit: We have at least two kinds of masks in BDR, so "...origin_set_mask..." and
"OriginSetMask", just for consistency and clarity.

[battre, 2012-06-14 09:24:52]

https://chromiumcodereview.appspot.com/10533147/diff/2001/chrome/browser/brow...
File chrome/browser/browsing_data_helper.h (right):

https://chromiumcodereview.appspot.com/10533147/diff/2001/chrome/browser/brow...
chrome/browser/browsing_data_helper.h:28: ALL = UNPROTECTED_WEB | PROTECTED_WEB
| EXTENSION,
On 2012/06/14 08:32:39, Mike West (chromium) wrote:
> Nit: Can you add a comment here, something like "totally always add new items
to
> the enum above ALL". I can imagine adding "apps" as a separate origin set at
> some point in the future, for instance.

Done.

https://chromiumcodereview.appspot.com/10533147/diff/2001/chrome/browser/brow...
File chrome/browser/browsing_data_remover.cc (right):

https://chromiumcodereview.appspot.com/10533147/diff/2001/chrome/browser/brow...
chrome/browser/browsing_data_remover.cc:210: forgotten_to_add_origin_mask_type);
On 2012/06/14 08:32:39, Mike West (chromium) wrote:
> Nit: We have at least two kinds of masks in BDR, so "...origin_set_mask..."
and
> "OriginSetMask", just for consistency and clarity.

Can't do that because UserMetricsAction(...) needs to fit into one line to be
discovered by a RegEx.

[commit-bot: I haz the power, 2012-06-14 09:26:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/10533147/4004

[commit-bot: I haz the power, 2012-06-14 11:42:08]

Change committed as 142125