Libraries should know their original URI, not their translated URI.

Libraries should know their original URI, not their translated URI.

For example, a library should know that it is package:a.dart, not file:///.../a.dart.

Committed: https://code.google.com/p/dart/source/detail?r=8606

[ahe, 2012-06-13 11:26:34]

This fixes http://code.google.com/p/dart/issues/detail?id=3147

A test is needed, but see: http://code.google.com/p/dart/issues/detail?id=3170
which is blocked on http://code.google.com/p/dart/issues/detail?id=3168

[kasperl, 2012-06-13 12:17:32]

LGTM. Do we have a test that covers the stuff in comment 3 in
http://code.google.com/p/dart/issues/detail?id=3147#c3? 

We probably already have some sort of test case that makes use of the default
package root -- maybe that could be extended to cover this as well?

[ahe, 2012-06-13 12:26:56]

On 2012/06/13 12:17:32, kasperl wrote:
> LGTM. Do we have a test that covers the stuff in comment 3 in
> http://code.google.com/p/dart/issues/detail?id=3147#c3? 
> 
> We probably already have some sort of test case that makes use of the default
> package root -- maybe that could be extended to cover this as well?

Hi Kasper,

Thank you for taking a look. I'm not sure you saw my original message:

A test is needed, but see: http://code.google.com/p/dart/issues/detail?id=3170
which is blocked on http://code.google.com/p/dart/issues/detail?id=3168

Currently, I have no way to test --package-root option.

[kasperl, 2012-06-13 12:28:49]

On 2012/06/13 12:26:56, ahe wrote:
> On 2012/06/13 12:17:32, kasperl wrote:
> > LGTM. Do we have a test that covers the stuff in comment 3 in
> > http://code.google.com/p/dart/issues/detail?id=3147#c3? 
> > 
> > We probably already have some sort of test case that makes use of the
default
> > package root -- maybe that could be extended to cover this as well?
> 
> Hi Kasper,
> 
> Thank you for taking a look. I'm not sure you saw my original message:
> 
> A test is needed, but see: http://code.google.com/p/dart/issues/detail?id=3170
> which is blocked on http://code.google.com/p/dart/issues/detail?id=3168
> 
> Currently, I have no way to test --package-root option.

My point was that you might be able to check things using the default package
root setting (no need to specify any options).

[ngeoffray, 2012-06-13 12:35:54]

LGTM. You can find a test case here:
https://chromiumcodereview.appspot.com/10534135/

https://chromiumcodereview.appspot.com/10533123/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/apiimpl.dart (right):

https://chromiumcodereview.appspot.com/10533123/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/apiimpl.dart:65: translateUri(Uri uri,
tree.Node node) {
Missing return type.

https://chromiumcodereview.appspot.com/10533123/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/apiimpl.dart:73: translateDartUri(Uri uri,
tree.Node node) {
ditto

[ahe, 2012-06-13 14:20:26]

Thank you.

https://chromiumcodereview.appspot.com/10533123/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/apiimpl.dart (right):

https://chromiumcodereview.appspot.com/10533123/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/apiimpl.dart:65: translateUri(Uri uri,
tree.Node node) {
On 2012/06/13 12:35:54, ngeoffray wrote:
> Missing return type.

Done.

https://chromiumcodereview.appspot.com/10533123/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/apiimpl.dart:73: translateDartUri(Uri uri,
tree.Node node) {
On 2012/06/13 12:35:54, ngeoffray wrote:
> ditto

Done.