Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 10533117: mac: Update menu item command IDs in MainMenu.xib. (Closed)

Created:
8 years, 6 months ago by Daniel Erat
Modified:
8 years, 6 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, Avi (use Gerrit)
Visibility:
Public.

Description

mac: Update menu item command IDs in MainMenu.xib. I renumbered some command IDs in r141609 but neglected to update the references to them in the NIB file. BUG=132322 TEST=none (grep for renumbered IDs in chrome/app/nibs and checked that they're correct) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/app/nibs/MainMenu.xib View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Daniel Erat
8 years, 6 months ago (2012-06-12 21:17:51 UTC) #1
Robert Sesek
LGTM And +1 for adding that comment.
8 years, 6 months ago (2012-06-12 21:23:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10533117/1
8 years, 6 months ago (2012-06-12 21:47:33 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 23:00:55 UTC) #4
Change committed as 141774

Powered by Google App Engine
This is Rietveld 408576698