Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 10533116: Unrevert 141514: Remove CachingValueStore in favor of an async ValueStoreFrontend. (Closed)

Created:
8 years, 6 months ago by Matt Perry
Modified:
8 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Unrevert 141514: Remove CachingValueStore in favor of an async ValueStoreFrontend. After actually seeing the use cases for the value store in extension code, I realized that an async version would be more appropriate. This one will use less memory as well, since we won't need to keep the cache in memory. BUG=123366, 132203 TEST=no Changes: Fixed a use-after-free bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141745

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -417 lines) Patch
M chrome/browser/extensions/settings/settings_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/settings/settings_quota_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/settings/settings_sync_unittest.cc View 9 chunks +13 lines, -19 lines 0 comments Download
D chrome/browser/value_store/caching_value_store.h View 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/value_store/caching_value_store.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/value_store/caching_value_store_unittest.cc View 1 chunk +0 lines, -113 lines 0 comments Download
M chrome/browser/value_store/failing_value_store.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/value_store/failing_value_store.cc View 1 chunk +11 lines, -11 lines 0 comments Download
M chrome/browser/value_store/testing_value_store.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/value_store/testing_value_store.cc View 5 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/value_store/testing_value_store_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/browser/value_store/value_store_frontend.h View 1 chunk +49 lines, -0 lines 0 comments Download
A chrome/browser/value_store/value_store_frontend.cc View 1 chunk +114 lines, -0 lines 1 comment Download
A + chrome/browser/value_store/value_store_frontend_unittest.cc View 4 chunks +32 lines, -29 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Matt Perry
http://codereview.chromium.org/10533116/diff/1/chrome/browser/value_store/value_store_frontend.cc File chrome/browser/value_store/value_store_frontend.cc (right): http://codereview.chromium.org/10533116/diff/1/chrome/browser/value_store/value_store_frontend.cc#newcode83 chrome/browser/value_store/value_store_frontend.cc:83: backend_, db_path)); This is what changed since last round. ...
8 years, 6 months ago (2012-06-12 20:42:16 UTC) #1
not at google - send to devlin
8 years, 6 months ago (2012-06-12 21:04:00 UTC) #2
lgtm

ah. tricky.

Powered by Google App Engine
This is Rietveld 408576698