Roll Skia DEPS to 4234 (inc changes to skia.gyp)

Roll Skia DEPS to 4234 (inc changes to skia.gyp)

https://chromiumcodereview.appspot.com/10548003/

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141741

[robertphillips, 2012-06-12 19:01:39]

I think this is okay. Do you all agree?


android   
	roll: good
	control: good
mac   
	roll: good
	control: good
mac_gpu   
	roll: good
	control: good
mac_asan  
	roll: compile failed 
	control: compile failed
linux   
	roll: good
	control:
		browser_tests - 6 failed + 6 flaky

			WebNavigationIFrame
			BrowserCloseInfiniteBeforeUnload
			BrowserCloseInfiniteBeforeUnloadAlert
			BrowserCloseInfiniteUnloadAlert
			TestSettingsFrameContentExceptionsPlugins
			TestSettingsFrameMangageProfile

		content_unittests - 1 failed

			GetUsageAndQuota_Simple

linux_gpu
	roll: good
	control:
		4 failed
				Canvas2DRedBoxSD
				CSS3DBlueBox
				Canvas2DRedBoxHD
				WebGLGreenTriangle
linux_asan   
	roll:
		browser tests - 6 flaky + 2 failed (Audio + SplitModeIncognito)
	control:
		browser_tests - 6 flaky + 2 failed (SplitModeIncognito + VideoBearTheora)

linux_heapcheck  
	roll: 	 38 disabled, crashed or hung
	control: 38 disabled, crashed or hung

linux_shared   
	roll: good
	control: good
linux_chromeos
	roll:
		browser_tests - 1 failed (Audio) + 7 flaky
	control:
		good

linux_chromeos_asan   
	roll: good
	control:
		browser_tests - 1 failed (PrerenderHTML5Audio) + 7 flaky

win   
	roll: good
	control: nacl_integration crashed or hung

win_gpu   
	roll: good
	control: update failed - client too old

mac_layout 
	roll: update failed (can't read file)
	control:
		webkit_tests - 1 failed (css3-modsel-d3.xml) + 3 flaky
				SVGFEConvolveMatrixElement-dom-order-attr.html
				customized-property-survives-gc.html
				SVGFEConvolveMatrixElement-dom-preserveAlpha-attr.html


mac_layout_rel   
	roll:
		webkit_tests - 1 failed (dfg-double-vote-fuzz.html) + 2 flaky
				access-after-page-destroyed.html
				test.html
	control: good

linux_layout   
	roll:
		webkit_tests - 1 failed (mouse-event.html) + 5 flaky
			
				fill-mode-iteration-count-non-integer.html
				?? video-media-source-seek.html
				cross-domain-message-event-dispatch.html
				track-cue-rendering-snap-to-lines-not-set.html
				?? block-selection-gap-in-composited-layer.html

	control:
		webkit_tests - 2 failed (loadInProgress.html mouse-event.html) + 11 flaky

				fill-mode-iteration-count-non-integer.html
				** 2d.text.draw.fill.maxWidth.gradient.html
				** async-onbeforeload.html
				cross-domain-message-event-dispatch.html
				track-cue-rendering-snap-to-lines-not-set.html
				** 3d-point-mapping-3.html
				** 3d-point-mapping-origins.html
				** 3d-point-mapping-overlapping.html
				** 3d-point-mapping-preserve-3d.html
				** 3d-point-mapping.html
				...and more				

linux_layout_rel   
	roll:
		webkit_tests - 2 failed + 3 flaky
				crash-restoring-plugin-page-from-page-cache.html 
				iframe-shims.html

				
				??live-edit.html
				track-cue-rendering-snap-to-lines-not-set.html
				?? block-selection-gap-in-composited-layer.html
	control:
		webkit_tests - 3 failed + 4 flaky
				
				**loadInProgress.html
				crash-restoring-plugin-page-from-page-cache.html
				iframe-shims.html

				**feTile.svg
				**textLength.svg
				**verticalText.svg
				track-cue-rendering-snap-to-lines-not-set.html

win_layout   
	roll: 
		webkit_tests - 1 failed (gamepad-polling-access.html) + 1 flaky
(redirect-cross-origin-post.html)
	control:
		update failed - client too old?

win_layout_rel   
	roll: good
	control: good

[Tom Hudson, 2012-06-12 19:06:55]

LGTM here

[epoger, 2012-06-12 19:09:02]

LGTM.

Again, I recommend you just disregard all "flaky" results entirely.

[reed1, 2012-06-12 19:44:51]

lgtm

[commit-bot: I haz the power, 2012-06-12 19:45:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertphillips@google.com/10533109/1

[commit-bot: I haz the power, 2012-06-12 21:35:07]

Change committed as 141741