Fixes memory leak

Fixes memory leak caused by 10545069

BUG=132231
TEST=Valgrind shows less memory leaks

TBR=sky

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141740

[Nico, 2012-06-12 14:37:13]

Can you remove the suppression for this as well?
On Jun 12, 2012 7:22 AM, <pkotwicz@chromium.org> wrote:

> Reviewers: Nico,
>
> Description:
> BUG=132231
> TEST=Valgrind shows less memory leaks
>
> Please review this at
http://codereview.chromium.**org/10533107/<http://codereview.chromium.org/105...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ui/gfx/image/image_mac_**unittest.mm <http://image_mac_unittest.mm>
>
>
> Index: ui/gfx/image/image_mac_**unittest.mm <http://image_mac_unittest.mm>
> diff --git
a/ui/gfx/image/image_mac_**unittest.mm<http://image_mac_unittest.mm>b/ui/gfx/image/
> image_mac_**unittest.mm <http://image_mac_unittest.mm>
> index 924cebd048f23d48100fb35665381d**117140b76c..**
> 1b199244c744ca70c2cc39576c0ce8**599da3c90f 100644
> --- a/ui/gfx/image/image_mac_**unittest.mm <http://image_mac_unittest.mm>
> +++ b/ui/gfx/image/image_mac_**unittest.mm <http://image_mac_unittest.mm>
> @@ -18,7 +18,7 @@ class ImageMacTest : public testing::Test {
>  public:
>   void CreateBitmapImageRep(int width, int height,
>                             NSBitmapImageRep** image_rep) {
> -    *image_rep = [[NSBitmapImageRep alloc]
> +    *image_rep = [[[NSBitmapImageRep alloc]
>         initWithBitmapDataPlanes:NULL
>                       pixelsWide:width
>                       pixelsHigh:height
> @@ -30,6 +30,8 @@ class ImageMacTest : public testing::Test {
>                     bitmapFormat:0
>                      bytesPerRow:0
>                     bitsPerPixel:0];
> +                    bitsPerPixel:0]
> +                 autorelease];
>   }
>  };
>
>
>
>

[pkotwicz, 2012-06-12 15:24:12]

Removed suppression as requested

[Nico, 2012-06-12 15:31:50]

lgtm

http://codereview.chromium.org/10533107/diff/6001/ui/gfx/image/image_mac_unit...
File ui/gfx/image/image_mac_unittest.mm (right):

http://codereview.chromium.org/10533107/diff/6001/ui/gfx/image/image_mac_unit...
ui/gfx/image/image_mac_unittest.mm:19: void CreateBitmapImageRep(int width, int
height,
nit: "Create" suggests that the caller is responsible for releasing the result,
maybe rename to just "BitmapImageRep()"?

[pkotwicz, 2012-06-12 17:31:49]

sky for OWNERS

[Nico, 2012-06-12 17:47:45]

For minor changes like this, feel free to add "TBR=sky" (or other owner) to the
CL description after adding them to the review, and then hitting the commit box.

[commit-bot: I haz the power, 2012-06-12 19:24:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10533107/5002

[commit-bot: I haz the power, 2012-06-12 19:24:39]

Presubmit check for 10533107-5002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
Add a description.

[commit-bot: I haz the power, 2012-06-12 20:16:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10533107/5002

[commit-bot: I haz the power, 2012-06-12 21:34:01]

Change committed as 141740